You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
build: change the release and staging branching model (#1042)
This pull request refactors the current branching model to improve development and address several challenges associated with using staging as the default base branch for pull requests. With this update, main will serve as the base branch for pull requests, containing active development changes, while releases will be triggered upon merging pull requests into the newly created release branch.
Signed-off-by: behnazh-w <[email protected]>
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
-1Lines changed: 0 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,7 +7,6 @@
7
7
-[ ] My PR title and commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) convention.
8
8
-[ ] My commits include the "Signed-off-by" line.
9
9
-[ ] I have signed my commits following the instructions provided by [GitHub](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). Note that we run [GitHub's commit verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) tool to check the commit signatures. A green `verified` label should appear next to **all** of your commits on GitHub.
10
-
-[ ] I have selected `staging` as the base branch for my PR.
11
10
-[ ] I have updated the relevant documentation, if applicable.
12
11
-[ ] I have tested my changes and verified they work as expected.
13
12
-[ ] I have referenced the issue(s) this pull request solves.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -35,13 +35,13 @@ See our [Macaron Style Guide](./docs/source/pages/developers_guide/style_guide.r
35
35
36
36
1. Ensure there is an issue created to track and discuss the fix or enhancement
37
37
you intend to submit.
38
-
2. Fork this repository including the `staging` branch. In Macaron, the `staging` branch is the active development branch and contains the most recent changes.
39
-
3. Create a branch in your fork to implement the changes. Make sure to create your branch from the `staging` branch and not `main`. We recommend using the issue number as part of your branch name, e.g. `1234-fixes`.
38
+
2. Fork this repository.
39
+
3. Create a branch in your fork to implement the changes. We recommend using the issue number as part of your branch name, e.g. `1234-fixes`.
40
40
4. The title of the PR should follow the convention of [commit messages](#commit-messages).
41
41
5. Ensure that any documentation is updated with the changes that are required by your change.
42
42
6. Ensure that any samples are updated if the base image has been changed.
43
43
7. Submit the pull request. *Do not leave the pull request blank*. Explain exactly what your changes are meant to do and provide simple steps on how to validate. your changes. Ensure that you reference the issue you created as well.
44
-
8. Choose `staging` as the base branch for your PR.
44
+
8. Choose `main` as the base branch for your PR.
45
45
9. We will assign the pull request to 2-3 people for review before it is merged.
46
46
47
47
### Commit messages
@@ -74,7 +74,7 @@ a detailed commit message body is preferred. Make sure to keep the `Signed-off-b
74
74
75
75
## Branching model
76
76
77
-
* The `main` branch is only used for releases and the `staging` branch is used for development. We only merge to `main` when we want to create a new release for Macaron.
77
+
* The `main` branch should be used as the base branch for pull requests. The `release` branch is designated for releases and should only be merged into when creating a new release for Macaron.
Copy file name to clipboardExpand all lines: docs/source/pages/installation.rst
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,7 +27,7 @@ Macaron is currently distributed as a Docker image. We provide a bash script ``r
27
27
28
28
.. note:: When run, Macaron will create output files inside the current directory where ``run_macaron.sh`` is run. If you run Docker Desktop, please make sure that the current directory is bind mountable for Docker (see the `File Sharing settings <https://docs.docker.com/desktop/settings/mac/?uuid=95C3E343-F11C-4A35-A10C-6B5431B73E14#file-sharing>`_).
29
29
30
-
Download the ``run_macaron.sh`` script and make it executable by running the commands (replace ``tag`` with the version you want or ``main`` for the latest version):
30
+
Download the ``run_macaron.sh`` script and make it executable by running the commands (replace ``tag`` with the version you want or ``release`` for the latest version):
Copy file name to clipboardExpand all lines: docs/source/pages/tutorials/use_verification_summary_attestation.rst
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -121,7 +121,7 @@ Here is a pretty-printed version of the policy as it appears in the VSA, along w
121
121
122
122
* Applying the Policy (``apply_policy_to``): To apply the ``gcn_provenance_policy``, Macaron first determines if the ``component_id`` is a valid component and if its ``PURL`` conforms to the pattern defined in the ``match`` predicate. If both conditions are met, the policy is applied.
123
123
124
-
* The template Datalog policy file can be downloaded from `here <https://github.com/oracle/macaron/tree/main/src/macaron/resources/policies/gdk/policy.dl.template>`_
124
+
* The template Datalog policy file can be downloaded from `here <https://github.com/oracle/macaron/tree/release/src/macaron/resources/policies/gdk/policy.dl.template>`_
125
125
126
126
Below you can find the template CUE file that has been used by the :ref:`mcn_provenance_expectation_1 <checks>` check at verification time to verify the provenance. It contains place holders for expected values that are populated by the GDK maintainers.
127
127
@@ -148,7 +148,7 @@ Here is a pretty-printed version of the policy as it appears in the VSA, along w
148
148
149
149
* ``projecturl: "https://<REPO_URL>"``: This checks that the ``projecturl`` attribute exactly matches the expected Repository URL. ``<REPO_URL>`` is a placeholder for the actual repository URL, e.g., ``internal.repo.com/micronaut-projects/micronaut-core``.
150
150
151
-
* The template CUE expectation can be downloaded from `this location <https://github.com/oracle/macaron/tree/main/src/macaron/resources/policies/gdk/expectation.cue.template>`_.
151
+
* The template CUE expectation can be downloaded from `this location <https://github.com/oracle/macaron/tree/release/src/macaron/resources/policies/gdk/expectation.cue.template>`_.
0 commit comments