Skip to content

Conversation

@art1f1c3R
Copy link
Member

@art1f1c3R art1f1c3R commented Sep 15, 2025

Summary

Following the addition of the MINIMAL_CONTENT, UNSECURE_DESCRIPTION, and STUB_NAME heuristics, some refactoring to their use in the ProbLog rules has been done to ensure no false negatives occur.

Description of changes

To better reflect their use and intention, the following names of heuristics were changed:

  • MINIMAL_CONTENT --> TYPE_STUB_FILE
  • UNSECURE_DESCRIPTION --> PACKAGE_DESCRIPTION_INTENT

Some keywords were also removed from the UNSECURE_DESCRIPTION heuristic to avoid missing packages which, whilst they may be test packages, are still should be detected by Macaron. Some unit tests have also been modified to reflect these changes, and avoid redundant pathway tests. Updates to documentation such as the README.md are also included.

Checklist

  • I have reviewed the contribution guide.
  • My PR title and commits follow the Conventional Commits convention.
  • My commits include the "Signed-off-by" line.
  • I have signed my commits following the instructions provided by GitHub. Note that we run GitHub's commit verification tool to check the commit signatures. A green verified label should appear next to all of your commits on GitHub.
  • I have updated the relevant documentation, if applicable.
  • I have tested my changes and verified they work as expected.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 15, 2025
@art1f1c3R art1f1c3R marked this pull request as ready for review September 15, 2025 06:51
@art1f1c3R art1f1c3R changed the title chore: refactor heuristic names and rules chore: change heuristic names and rules Sep 15, 2025
@behnazh-w behnazh-w added this to the Release version 0.18.0 milestone Sep 16, 2025
@behnazh-w behnazh-w merged commit bfa4a33 into main Sep 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants