chore: change heuristic names and rules #1176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the addition of the
MINIMAL_CONTENT,UNSECURE_DESCRIPTION, andSTUB_NAMEheuristics, some refactoring to their use in the ProbLog rules has been done to ensure no false negatives occur.Description of changes
To better reflect their use and intention, the following names of heuristics were changed:
MINIMAL_CONTENT-->TYPE_STUB_FILEUNSECURE_DESCRIPTION-->PACKAGE_DESCRIPTION_INTENTSome keywords were also removed from the
UNSECURE_DESCRIPTIONheuristic to avoid missing packages which, whilst they may be test packages, are still should be detected by Macaron. Some unit tests have also been modified to reflect these changes, and avoid redundant pathway tests. Updates to documentation such as theREADME.mdare also included.Checklist
verifiedlabel should appear next to all of your commits on GitHub.