Open
Conversation
cboffa13
reviewed
Jan 8, 2026
Member
There was a problem hiding this comment.
Do we have tests for this file?
cboffa13
reviewed
Jan 8, 2026
| ) | ||
| assert response is not None | ||
| assert not response.is_error | ||
| mock_invoke.assert_called_once() |
Member
There was a problem hiding this comment.
Much of these unit tests arent really asserting anything specific, just that the mock's are called. Is there anyway we can make sure the logic is being tested more thoroughly?
3af1167 to
7a81ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the OCI DB Dynamic MCP Server, a fully functional Model Context Protocol server that enables LLMs to interact with Oracle Cloud Infrastructure Database services.
Unlike static tool definitions, this server dynamically loads OCI specifications to generate tools on the fly, ensuring up-to-date compatibility with OCI APIs.
Key Features Implemented:
OCI_ALLOWED_RESOURCES) filter to optimize context size and startup time.SecurityTokenSignerand config file authentication.Fixes # (Initial Release / Feature Request ID)
Type of change
How Has This Been Tested?
I have implemented a comprehensive test suite that validates both the dynamic tool generation and the API invocation logic.
build_tools_from_latest_speccorrectly parses OCI specs and handles schema flattening.database,db_system,autonomous_database) to verify payload reconstruction.Checklist: