Remove two network-dependent tests

Author: cjbj

test/connection.js

@@ -740,30 +740,8 @@ describe('1. connection.js', function(){
     });
   }); // 1.6
 
-  describe('1.7 invalid credentials', function() {
-
-    it('1.7.1 cannot get connections with invalid credentials', function(done) {
-
-      oracledb.getConnection(
-        {
-          user: 'notexist',
-          password: 'nopass',
-          connectString: dbConfig.connectString
-        },
-        function(err, connection) {
-          should.exist(err);
-          (err.message).should.startWith('ORA-01017:');
-          should.not.exist(connection);
-          done();
-        }
-      );
-
-    });
-
-  }); // 1.7
-
-  describe('1.8 connectionString alias', function() {
-    it('1.8.1 allows connectionString to be used as an alias for connectString', function(done) {
+  describe('1.7 connectionString alias', function() {
+    it('1.7.1 allows connectionString to be used as an alias for connectString', function(done) {
       oracledb.getConnection(
         {
           user: dbConfig.user,
@@ -784,46 +762,11 @@ describe('1. connection.js', function(){
       );
     });
 
-    it('1.8.2 favors connectString if both connectString and connectionString are passed', function(done) {
-      oracledb.getConnection(
-        {
-          user: dbConfig.user,
-          password: dbConfig.password,
-          connectString: 'this is wrong',
-          connectionString: dbConfig.connectString
-        },
-        function(err, conn) {
-          should.exist(err);
-          // ORA-12154: TNS:could not resolve the connect identifier specified
-          should.not.exist(conn);
-
-          oracledb.getConnection(
-            {
-              user: dbConfig.user,
-              password: dbConfig.password,
-              connectString: dbConfig.connectString,
-              connectionString: 'this is wrong'
-            },
-            function(err, connection) {
-              should.not.exist(err);
-
-              connection.should.be.ok();
-
-              connection.close(function(err) {
-                should.not.exist(err);
-
-                done();
-              });
-            }
-          );
-        }
-      );
-    });
-  }); // 1.8
+  }); // 1.7
 
-  describe('1.9 privileged connnections', function() {
+  describe('1.8 privileged connnections', function() {
 
-    it('1.9.1 Negative value - null', function(done) {
+    it('1.8.1 Negative value - null', function(done) {
 
       oracledb.getConnection(
         {
@@ -842,9 +785,9 @@ describe('1. connection.js', function(){
           done();
         }
       );
-    }); // 1.9.1
+    }); // 1.8.1
 
-    it('1.9.2 Negative - invalid type, a String', function(done) {
+    it('1.8.2 Negative - invalid type, a String', function(done) {
 
       oracledb.getConnection(
         {
@@ -863,9 +806,9 @@ describe('1. connection.js', function(){
           done();
         }
       );
-    }); // 1.9.2
+    }); // 1.8.2
 
-    it('1.9.3 Negative value - random constants', function(done) {
+    it('1.8.3 Negative value - random constants', function(done) {
 
       oracledb.getConnection(
         {
@@ -882,9 +825,9 @@ describe('1. connection.js', function(){
           done();
         }
       );
-    }); // 1.9.3
+    }); // 1.8.3
 
-    it('1.9.4 Negative value - NaN', function(done) {
+    it('1.8.4 Negative value - NaN', function(done) {
 
       oracledb.getConnection(
         {
@@ -903,9 +846,9 @@ describe('1. connection.js', function(){
           done();
         }
       );
-    }); // 1.9.4
+    }); // 1.8.4
 
-    it('1.9.5 gets ignored when acquiring a connection from Pool', function(done) {
+    it('1.8.5 gets ignored when acquiring a connection from Pool', function(done) {
 
       oracledb.createPool(
         {
@@ -932,8 +875,8 @@ describe('1. connection.js', function(){
           });
         }
       );
-    }); // 1.9.5
+    }); // 1.8.5
 
-  }); // 1.9
+  }); // 1.8
 
 });

test/list.txt

@@ -23,17 +23,14 @@ Overview of node-oracledb functional tests
         1.5.6 wrong type for param 4 should throw an error
     1.6 Close method
         1.6.1 close can be used as an alternative to release
-    1.7 invalid credentials
-        1.7.1 cannot get connections with invalid credentials
-    1.8 connectionString alias
-        1.8.1 allows connectionString to be used as an alias for connectString
-        1.8.2 favors connectString if both connectString and connectionString are passed
-    1.9 privileged connnections
-        1.9.1 Negative value - null
-        1.9.2 Negative - invalid type, a String
-        1.9.3 Negative value - random constants
-        1.9.4 Negative value - NaN
-        1.9.5 gets ignored when acquiring a connection from Pool
+    1.7 connectionString alias
+        1.7.1 allows connectionString to be used as an alias for connectString
+    1.8 privileged connnections
+        1.8.1 Negative value - null
+        1.8.2 Negative - invalid type, a String
+        1.8.3 Negative value - random constants
+        1.8.4 Negative value - NaN
+        1.8.5 gets ignored when acquiring a connection from Pool
 
 2. pool.js
     2.1 default values