Skip to content

Commit b805a3b

Browse files
committed
Fix bug with executeMany() OUT binds using connections
1 parent d4ca984 commit b805a3b

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@
8787
- Fixed crashes seen with Worker threads ([ODPI-C
8888
change](https://github.com/oracle/odpi/commit/09da0065409702cc28ba622951ca999a6b77d0e9)).
8989

90+
- Fixed a failure when using JavaScript functions on OUT bind variables from
91+
`executeMany()` that require the connection, for example accessing database
92+
objects or streaming LOBs.
93+
9094
- Test and documentation improvements.
9195

9296
## node-oracledb v5.1.0 (8 Dec 2020)

src/njsConnection.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,6 +871,10 @@ static bool njsConnection_executeManyPostAsync(njsBaton *baton, napi_env env,
871871
uint32_t numOutBinds;
872872
napi_value temp;
873873

874+
// set JavaScript values to simplify creation of returned objects
875+
if (!njsBaton_setJsValues(baton, env))
876+
return false;
877+
874878
// create object for result
875879
NJS_CHECK_NAPI(env, napi_create_object(env, result))
876880

0 commit comments

Comments
 (0)