Add unit test to for merging common tags tags at the time of creation of LB & storage resources

Merge common free-form & defined tags to LB, NLB & FSS during provision

Squashed commit:
fix not using generics to remove Go >=1.18 dependency

Author: GouthamML

pkg/cloudprovider/providers/oci/config/config.go

@@ -22,7 +22,6 @@ import (
 	"github.com/oracle/oci-go-sdk/v65/common"
 	"github.com/oracle/oci-go-sdk/v65/common/auth"
 	"github.com/pkg/errors"
-
 	"go.uber.org/zap"
 	"gopkg.in/yaml.v2"
 )
@@ -127,6 +126,7 @@ type InitialTags struct {
 	LoadBalancer *TagConfig `yaml:"loadBalancer"`
 	BlockVolume  *TagConfig `yaml:"blockVolume"`
 	FSS          *TagConfig `yaml:"fss"`
+	Common       *TagConfig `yaml:"common"`
 }
 
 // Config holds the OCI cloud-provider config passed to Kubernetes components
@@ -151,7 +151,7 @@ type Config struct {
 	// cluster resides.
 	VCNID string `yaml:"vcn"`
 
-	//Metadata service to help fill in certain fields
+	// Metadata service to help fill in certain fields
 	metadataSvc metadata.Interface
 }
 

pkg/cloudprovider/providers/oci/load_balancer_spec.go

@@ -17,6 +17,7 @@ package oci
 import (
 	"encoding/json"
 	"fmt"
+	"github.com/oracle/oci-cloud-controller-manager/pkg/util"
 	"net"
 	"net/http"
 	"strconv"
@@ -377,6 +378,10 @@ func NewLBSpec(logger *zap.SugaredLogger, svc *v1.Service, nodes []*v1.Node, sub
 	if err != nil {
 		return nil, err
 	}
+	// merge lbtags with common tags if present
+	if util.IsCommonTagPresent(initialLBTags) {
+		lbTags = util.MergeTagConfig(lbTags, initialLBTags.Common)
+	}
 
 	ruleManagementMode, managedNsg, err := getRuleManagementMode(svc)
 	if err != nil {
@@ -1286,6 +1291,7 @@ func getLoadBalancerTags(svc *v1.Service, initialTags *config.InitialTags) (*con
 	if initialTags == nil || initialTags.LoadBalancer == nil {
 		return &config.TagConfig{}, nil
 	}
+
 	// return initial tags
 	return initialTags.LoadBalancer, nil
 }