use connectTimeout for all API calls

fixes #4210

Author: vladak

opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/RuntimeEnvironment.java

@@ -1555,22 +1555,27 @@ public String getConfigurationXML() {
     public void writeConfiguration(String host) throws IOException, InterruptedException, IllegalArgumentException {
         String configXML = syncReadConfiguration(Configuration::getXMLRepresentationAsString);
 
-        Response response = ClientBuilder.newClient()
+        try (Response response = ClientBuilder.newBuilder().
+                connectTimeout(getConnectTimeout(), TimeUnit.SECONDS).build()
                 .target(host)
                 .path("api")
                 .path("v1")
                 .path("configuration")
                 .queryParam("reindex", true)
                 .request()
                 .headers(getWebAppHeaders())
-                .put(Entity.xml(configXML));
+                .put(Entity.xml(configXML))) {
 
-        if (response.getStatus() == Response.Status.ACCEPTED.getStatusCode()) {
-            response = ApiUtils.waitForAsyncApi(response);
-        }
+            Response.StatusType statusType = response.getStatusInfo();
+
+            if (response.getStatus() == Response.Status.ACCEPTED.getStatusCode()) {
+                Response apiResponse = ApiUtils.waitForAsyncApi(response);
+                statusType = apiResponse.getStatusInfo();
+            }
 
-        if (response.getStatusInfo().getFamily() != Response.Status.Family.SUCCESSFUL) {
-            throw new IOException(response.toString());
+            if (statusType.getFamily() != Response.Status.Family.SUCCESSFUL) {
+                throw new IOException(response.toString());
+            }
         }
     }
 

opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexerUtil.java

@@ -36,6 +36,8 @@
 import jakarta.ws.rs.core.MultivaluedMap;
 import jakarta.ws.rs.core.Response;
 
+import java.util.concurrent.TimeUnit;
+
 public class IndexerUtil {
 
     private IndexerUtil() {
@@ -70,7 +72,8 @@ public static void enableProjects(final String host) throws
             ProcessingException,
             WebApplicationException {
 
-        try (Client client = ClientBuilder.newClient()) {
+        try (Client client = ClientBuilder.newBuilder().
+                connectTimeout(RuntimeEnvironment.getInstance().getConnectTimeout(), TimeUnit.SECONDS).build()) {
             final Invocation.Builder request = client.target(host)
                     .path("api")
                     .path("v1")

opengrok-indexer/src/main/java/org/opengrok/indexer/web/ApiUtils.java

@@ -18,7 +18,7 @@
  */
 
 /*
- * Copyright (c) 2021, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2021, 2023, Oracle and/or its affiliates. All rights reserved.
  */
 package org.opengrok.indexer.web;
 
@@ -37,6 +37,8 @@ public class ApiUtils {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(ApiUtils.class);
 
+    private static final RuntimeEnvironment env = RuntimeEnvironment.getInstance();
+
     private ApiUtils() {
         // utility class
     }
@@ -66,9 +68,9 @@ private ApiUtils() {
         }
 
         LOGGER.log(Level.FINER, "checking asynchronous API result on {0}", location);
-        for (int i = 0; i < RuntimeEnvironment.getInstance().getApiTimeout(); i++) {
+        for (int i = 0; i < env.getApiTimeout(); i++) {
             response = ClientBuilder.newBuilder().
-                    connectTimeout(RuntimeEnvironment.getInstance().getConnectTimeout(), TimeUnit.SECONDS).build().
+                    connectTimeout(env.getConnectTimeout(), TimeUnit.SECONDS).build().
                     target(location).request().get();
             if (response.getStatus() == Response.Status.ACCEPTED.getStatusCode()) {
                 Thread.sleep(1000);
@@ -83,11 +85,13 @@ private ApiUtils() {
         }
 
         LOGGER.log(Level.FINER, "making DELETE API request to {0}", location);
-        Response deleteResponse = ClientBuilder.newBuilder().connectTimeout(3, TimeUnit.SECONDS).build().
-                target(location).request().delete();
-        if (deleteResponse.getStatusInfo().getFamily() != Response.Status.Family.SUCCESSFUL) {
-            LOGGER.log(Level.WARNING, "DELETE API call to {0} failed with HTTP error {1}",
-                    new Object[]{location, response.getStatusInfo()});
+        try (Response deleteResponse = ClientBuilder.newBuilder().
+                connectTimeout(env.getConnectTimeout(), TimeUnit.SECONDS).build().
+                target(location).request().delete()) {
+            if (deleteResponse.getStatusInfo().getFamily() != Response.Status.Family.SUCCESSFUL) {
+                LOGGER.log(Level.WARNING, "DELETE API call to {0} failed with HTTP error {1}",
+                        new Object[]{location, response.getStatusInfo()});
+            }
         }
 
         return response;

plugins/src/main/java/opengrok/auth/plugin/util/RestfulClient.java

@@ -29,7 +29,9 @@
 import jakarta.ws.rs.client.Entity;
 import jakarta.ws.rs.core.MediaType;
 import jakarta.ws.rs.core.Response;
+import org.opengrok.indexer.configuration.RuntimeEnvironment;
 
+import java.util.concurrent.TimeUnit;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -52,7 +54,8 @@ private RestfulClient() {
     public static int postIt(String uri, String input) {
         int result;
         try {
-            try (Client client = ClientBuilder.newClient()) {
+            try (Client client = ClientBuilder.newBuilder().
+                    connectTimeout(RuntimeEnvironment.getInstance().getConnectTimeout(), TimeUnit.SECONDS).build()) {
                 LOGGER.log(Level.FINEST, "sending REST POST request to {0}: {1}",
                         new Object[]{uri, input});
                 try (Response response = client.target(uri)