add elapsed statistics logs to suggester rebuild #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahornace
reviewed
Jul 19, 2018
suggester/src/main/java/org/opengrok/suggest/util/StringUtils.java
Outdated
Show resolved
Hide resolved
suggester/src/main/java/org/opengrok/suggest/util/Statistics.java
Outdated
Show resolved
Hide resolved
suggester/src/main/java/org/opengrok/suggest/util/Statistics.java
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 2813
💛 - Coveralls |
Closed
tulinkry
reviewed
Jul 26, 2018
suggester/src/main/java/org/opengrok/suggest/util/Statistics.java
Outdated
Show resolved
Hide resolved
tulinkry
reviewed
Jul 26, 2018
suggester/src/main/java/org/opengrok/suggest/util/Statistics.java
Outdated
Show resolved
Hide resolved
tulinkry
reviewed
Jul 26, 2018
suggester/src/main/java/org/opengrok/suggest/util/StringUtils.java
Outdated
Show resolved
Hide resolved
|
@vladak do you plan to continue working on this? It's been over a year. |
vladak
force-pushed
the
suggester_elapsed_stats
branch
from
0948ffc to
c697e82
Compare
|
In the end I got rid of both previously added classes. Please take a look again. |
ahornace
reviewed
Aug 13, 2019
added 2 commits
August 13, 2019 14:04
ahornace
reviewed
Aug 13, 2019
ahornace
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another piece that reports how long does suggester rebuild take. Had to get the methods from the indexer as suggester is independent.