Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| public BitIntsHolder reduce(Collection<SuggestResultCollector> collectors) { | ||
| BitIntsHolder reduced = documentIds; | ||
| for (SuggestResultCollector collector : collectors) { | ||
| documentIds.or(collector.documentIds); //TODO fix as per https://github.com/apache/lucene/pull/766/files |
|
seems SuggestResultCollector.java has no testing coverage ... |
|
@ahornace any clues for proper fixing of reduce for that collector? Is it even used? |
|
|
||
| private void searchIndex(IndexSearcher searcher, boolean paging) throws IOException { | ||
| collector = TopScoreDocCollector.create(hitsPerPage * cachePages, Short.MAX_VALUE); | ||
| collectorManager = new TopScoreDocCollectorManager(hitsPerPage * cachePages, Short.MAX_VALUE); |
There was a problem hiding this comment.
perhaps redesign to reuse the object?
(supress-es should be reviewed, scorer returns bad objects, so it should break scorer tests)
|
lucene 10 support needs to be rewritten into new PR |
tarzanek
force-pushed
the
lucene-9.10.0
branch
from
179fdb9 to
4374b79
Compare
tarzanek
force-pushed
the
lucene-9.10.0
branch
from
4374b79 to
7834538
Compare
| url.getHost(), url.getPort(), | ||
| url.getPath(), url.getQuery(), url.getRef()); | ||
| public static String encodeURL(String urlStr) throws URISyntaxException { | ||
| // URL url = new URL(urlStr); - this call |
There was a problem hiding this comment.
I took a longer look at the departure from the URL() constructors yesterday. The URL class by itself does not support any encoding/decoding, it merely breaks down the URL into pieces. The encoding is then supplied by the URI class.
The problem is that URI(String) accepts only already encoded URIs and refuses any non-compliant characters. I think the way to go is to propagate the URL object all the way where possible, i.e. change the String url parameter type of the various linkify() and buildLink() methods to URL url and avoid passing the url in the map of attributes as String - pass it as an extra argument with the URL type.
It is still not clear to me where the unescaped characters could originate from.
|
I will split lucene 10 changes away from this PR, get the lucene 9 done (I think only suggester test is missing before it can be merged) |
Java 21 conversion has just been done. |
|
cool, so I should be ready to revive this draft and ev. let AI do the lucene upgrade :-D, let's try |
|
will close this in favour of #4929 |
2 participants
No description provided.