Skip to content

Conversation

navinp0304
Copy link
Contributor

As of now fortran indexing is broken because of my previous change.

 Second argument of substring is wrong in my previous commit 

It should be 
cmatch.substring(cmatch.length() - 1, cmatch.length()) instead of  cmatch.substring(cmatch.length() - 1, 1)

@vladak Please review

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2024
@vladak
Copy link
Member

vladak commented Dec 2, 2024

Looks good, although I am surprised there is no change to the test data.

@vladak
Copy link
Member

vladak commented Dec 5, 2024

Looks good, although I am surprised there is no change to the test data.

I mean - if the change broke Fortran, there should be some sort of test case to cover this.

@vladak vladak merged commit 5289f7a into oracle:master Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants