Skip to content

Fix some code smells #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

Fix some code smells #4839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5062ef
remove redundant public modifier
vladak Sep 2, 2025
3e992c1
check results of mkdirs()/delete()
vladak Sep 2, 2025
97bec41
remove redundant image word
vladak Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opengrok-web/src/main/webapp/diff.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ include file="/mast.jsp"
</thead>
<tbody>
<tr>
<td><img src="<%= link %>?<%= QueryParameters.REVISION_PARAM_EQ %><%= Util.uriEncode(data.getRev(0)) %>" alt="previous image"/>
<td><img src="<%= link %>?<%= QueryParameters.REVISION_PARAM_EQ %><%= Util.uriEncode(data.getRev(0)) %>" alt="previous"/>
</td>
<td><img src="<%= link %>?<%= QueryParameters.REVISION_PARAM_EQ %><%= Util.uriEncode(data.getRev(1)) %>" alt="new image"/>
<td><img src="<%= link %>?<%= QueryParameters.REVISION_PARAM_EQ %><%= Util.uriEncode(data.getRev(1)) %>" alt="new"/>
</td>
</tr>
</tbody>
Expand Down
6 changes: 3 additions & 3 deletions opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class PageConfigTest {
private static TestRepository repository = new TestRepository();

@BeforeAll
public static void setUpClass() throws Exception {
static void setUpClass() throws Exception {
RuntimeEnvironment env = RuntimeEnvironment.getInstance();
env.setHistoryEnabled(true);

Expand Down Expand Up @@ -598,8 +598,8 @@ void testCheckSourceRootExistence5() throws IOException {
PageConfig cfg = PageConfig.get(req);
String path = RuntimeEnvironment.getInstance().getSourceRootPath();
File temp = File.createTempFile("opengrok", "-test-file.tmp");
temp.delete();
temp.mkdirs();
assertTrue(temp.delete());
assertTrue(temp.mkdirs());
RuntimeEnvironment.getInstance().setSourceRoot(temp.getAbsolutePath());
cfg.checkSourceRootExistence();
RuntimeEnvironment.getInstance().setSourceRoot(path);
Expand Down
Loading