Enable pattern matching by default and remove the option

Author: eregon

CHANGELOG.md

@@ -3,6 +3,7 @@
 New features:
 
 * C/C++ extensions are now compiled using the system toolchain and executed natively instead of using GraalVM LLVM (Sulong). This leads to faster startup, no warmup, better compatibility, smaller distribution and faster installation for C/C++ extensions (#3118, @eregon).
+* Pattern matching is now fully supported, with the exception of Find pattern (`in [*, a, *]`) (#3332, #2683, @eregon, @razetime).
 
 Bug fixes:
 

src/main/java/org/truffleruby/options/Options.java

@@ -67,8 +67,6 @@ public final class Options {
     public final boolean HOST_INTEROP;
     /** --trace-calls=true */
     public final boolean TRACE_CALLS;
-    /** --pattern-matching=false */
-    public final boolean PATTERN_MATCHING;
     /** --patching=true */
     public final boolean PATCHING;
     /** --hashing-deterministic=false */
@@ -230,7 +228,6 @@ public Options(Env env, OptionValues options, LanguageOptions languageOptions) {
         POLYGLOT_STDIO = options.hasBeenSet(OptionsCatalog.POLYGLOT_STDIO_KEY) ? options.get(OptionsCatalog.POLYGLOT_STDIO_KEY) : EMBEDDED || !NATIVE_PLATFORM;
         HOST_INTEROP = env.isHostLookupAllowed() && (options.get(OptionsCatalog.HOST_INTEROP_KEY));
         TRACE_CALLS = options.get(OptionsCatalog.TRACE_CALLS_KEY);
-        PATTERN_MATCHING = options.get(OptionsCatalog.PATTERN_MATCHING_KEY);
         PATCHING = options.get(OptionsCatalog.PATCHING_KEY);
         HASHING_DETERMINISTIC = options.get(OptionsCatalog.HASHING_DETERMINISTIC_KEY);
         VIRTUAL_THREAD_FIBERS = options.get(OptionsCatalog.VIRTUAL_THREAD_FIBERS_KEY);
@@ -346,8 +343,6 @@ public Object fromDescriptor(OptionDescriptor descriptor) {
                 return HOST_INTEROP;
             case "ruby.trace-calls":
                 return TRACE_CALLS;
-            case "ruby.pattern-matching":
-                return PATTERN_MATCHING;
             case "ruby.patching":
                 return PATCHING;
             case "ruby.hashing-deterministic":

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -782,16 +782,6 @@ public RubyNode visitCaseNode(CaseParseNode node) {
     public RubyNode visitCaseInNode(CaseInParseNode node) {
         final SourceIndexLength sourceSection = node.getPosition();
 
-        if (!RubyLanguage.getCurrentContext().getOptions().PATTERN_MATCHING) {
-            final RubyContext context = RubyLanguage.getCurrentContext();
-            throw new RaiseException(
-                    context,
-                    context.getCoreExceptions().syntaxError(
-                            "syntax error, unexpected keyword_in",
-                            currentNode,
-                            sourceSection.toSourceSection(source)));
-        }
-
         PatternMatchingTranslator translator = new PatternMatchingTranslator(language, source, parserContext,
                 currentNode, environment, this);
 

src/main/java/org/truffleruby/parser/YARPTranslator.java

@@ -922,12 +922,6 @@ public RubyNode visitCapturePatternNode(Nodes.CapturePatternNode node) {
 
     @Override
     public RubyNode visitCaseMatchNode(Nodes.CaseMatchNode node) {
-        var context = RubyLanguage.getCurrentContext();
-        if (!context.getOptions().PATTERN_MATCHING) {
-            throw new RaiseException(context, context.getCoreExceptions().syntaxError(
-                    "`case/in` pattern matching not yet implemented", currentNode, getSourceSection(node)));
-        }
-
         var translator = new YARPPatternMatchingTranslator(language, environment, rubySource, this);
 
         // Evaluate the case expression and store it in a local
@@ -2569,12 +2563,6 @@ public RubyNode visitMatchPredicateNode(Nodes.MatchPredicateNode node) {
 
     @Override
     public RubyNode visitMatchRequiredNode(Nodes.MatchRequiredNode node) {
-        var context = RubyLanguage.getCurrentContext();
-        if (!context.getOptions().PATTERN_MATCHING) {
-            throw new RaiseException(context, context.getCoreExceptions()
-                    .syntaxError("`=>` pattern matching not yet implemented", currentNode, getSourceSection(node)));
-        }
-
         var translator = new YARPPatternMatchingTranslator(language, environment, rubySource, this);
 
         // Evaluate the expression and store it in a local

src/options.yml

@@ -97,7 +97,6 @@ EXPERT:
     # Ruby-level features
     TRACE_CALLS: [trace-calls, boolean, true, 'Support tracing (set_trace_func, TracePoint) of method calls']
     COVERAGE_GLOBAL: [coverage-global, boolean, false, Run coverage for all code and print results on exit]
-    PATTERN_MATCHING: [pattern-matching, boolean, false, Enable pattern matching syntax]
 
     # Options helpful for debugging, potentially also for user code
     CORE_AS_INTERNAL: [core-as-internal, boolean, false, 'Mark core library sources as internal']

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -46,7 +46,6 @@ public final class OptionsCatalog {
     public static final OptionKey<Boolean> HOST_INTEROP_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> TRACE_CALLS_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> COVERAGE_GLOBAL_KEY = new OptionKey<>(false);
-    public static final OptionKey<Boolean> PATTERN_MATCHING_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> CORE_AS_INTERNAL_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> STDLIB_AS_INTERNAL_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> LAZY_TRANSLATION_USER_KEY = new OptionKey<>(LAZY_CALLTARGETS_KEY.getDefaultValue());
@@ -375,14 +374,6 @@ public final class OptionsCatalog {
             .usageSyntax("")
             .build();
 
-    public static final OptionDescriptor PATTERN_MATCHING = OptionDescriptor
-            .newBuilder(PATTERN_MATCHING_KEY, "ruby.pattern-matching")
-            .help("Enable pattern matching syntax")
-            .category(OptionCategory.EXPERT)
-            .stability(OptionStability.EXPERIMENTAL)
-            .usageSyntax("")
-            .build();
-
     public static final OptionDescriptor CORE_AS_INTERNAL = OptionDescriptor
             .newBuilder(CORE_AS_INTERNAL_KEY, "ruby.core-as-internal")
             .help("Mark core library sources as internal")
@@ -1389,8 +1380,6 @@ public static OptionDescriptor fromName(String name) {
                 return TRACE_CALLS;
             case "ruby.coverage-global":
                 return COVERAGE_GLOBAL;
-            case "ruby.pattern-matching":
-                return PATTERN_MATCHING;
             case "ruby.core-as-internal":
                 return CORE_AS_INTERNAL;
             case "ruby.stdlib-as-internal":
@@ -1662,7 +1651,6 @@ public static OptionDescriptor[] allDescriptors() {
             HOST_INTEROP,
             TRACE_CALLS,
             COVERAGE_GLOBAL,
-            PATTERN_MATCHING,
             CORE_AS_INTERNAL,
             STDLIB_AS_INTERNAL,
             LAZY_TRANSLATION_USER,

tool/docker.rb

@@ -259,7 +259,6 @@ def docker(*args)
 
           %w[:command_line :security :language :core :tracepoint :library :capi :library_cext :truffle :truffle_capi].each do |set|
             t_config = c.empty? ? '' : '-T' + c
-            t_config += ' -T--experimental-options -T--pattern-matching'
             t_excludes = excludes.map { |e| '--excl-tag ' + e }.join(' ')
             lines << "RUN ruby spec/mspec/bin/mspec -t #{ruby_bin}/ruby #{t_config} #{t_excludes} #{set}"
           end

tool/jt.rb

@@ -1706,8 +1706,6 @@ def mspec(*args)
 
 
     vm_args << '--polyglot' if truffleruby_jvm?
-    # Until pattern matching is complete, we enable it in specs but not globally
-    vm_args << '--experimental-options' << '--pattern-matching'
 
     raise "unsupported options #{parsed_options}" unless parsed_options.empty?