Feedback

Author: chrisseaton

src/main/java/org/truffleruby/core/hash/library/HashStoreLibrary.java

@@ -47,14 +47,14 @@ public static HashStoreLibrary createDispatched() {
         return FACTORY.createDispatched(HashGuards.hashStrategyLimit());
     }
 
-    public static HashStoreLibrary createUncached(RubyHash hash) {
+    public static HashStoreLibrary getUncached(RubyHash hash) {
         final Object store = hash.store;
         return FACTORY.getUncached(store);
     }
 
     public static boolean verify(RubyHash hash) {
         final Object store = hash.store;
-        return createUncached(hash).verify(store, hash);
+        return getUncached(hash).verify(store, hash);
     }
 
     /** Looks up the key in the hash and returns the associated value, or the result of calling {@code defaultNode} if

src/main/java/org/truffleruby/language/arguments/KeywordArgumentsDescriptor.java

@@ -9,15 +9,17 @@
  */
 package org.truffleruby.language.arguments;
 
+import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
+
 /** An arguments descriptor that says that keyword arguments were passed (either foo(a: 1) or foo(**kw)). Note that
  * currently, if kw is empty, then this descriptor is used even though it is semantically the same as if no keyword
  * arguments were passed. The callee must handle that for now. */
 public class KeywordArgumentsDescriptor extends ArgumentsDescriptor {
 
-    private final String[] keywords;
+    @CompilationFinal(dimensions = 1) private final String[] keywords;
 
     /** Use {@link KeywordArgumentsDescriptorManager} to get an instance. */
-    public KeywordArgumentsDescriptor(String[] keywords) {
+    KeywordArgumentsDescriptor(String[] keywords) {
         this.keywords = keywords;
     }
 

src/main/java/org/truffleruby/language/arguments/ReadUserKeywordsHashNode.java

@@ -35,13 +35,13 @@ public RubyHash execute(VirtualFrame frame) {
 
     /** Verify that all keywords the descriptor claims should be in the hash, are in fact in the hash. **/
     private boolean assertHashMatchesDescriptor(RubyHash hash, KeywordArgumentsDescriptor descriptor) {
-        final HashStoreLibrary hashStoreLibrary = HashStoreLibrary.createUncached(hash);
+        final HashStoreLibrary hashStoreLibrary = HashStoreLibrary.getUncached(hash);
 
         for (String keyword : descriptor.getKeywords()) {
             final RubySymbol symbol = getSymbol(keyword);
             final Object value = hashStoreLibrary.lookupOrDefault(hash.store, null, hash, symbol, (f, h, k) -> null);
             assert value != null : "descriptor claims " + keyword +
-                    " was a passed as a keyword argument but it's not in the hash";
+                    " was passed as a keyword argument but it's not in the hash";
         }
         return true;
     }

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -59,6 +59,7 @@
 import org.truffleruby.core.rope.RopeConstants;
 import org.truffleruby.core.string.FrozenStrings;
 import org.truffleruby.core.string.InterpolatedStringNode;
+import org.truffleruby.core.string.StringUtils;
 import org.truffleruby.core.support.TypeNodes;
 import org.truffleruby.core.string.ImmutableRubyString;
 import org.truffleruby.language.LexicalScope;
@@ -3149,7 +3150,7 @@ private static ArgumentsDescriptor getKeywordArgumentsDescriptor(RubyLanguage la
 
         if (splat || nonKeywordKeys || !keywords.isEmpty()) {
             return language.keywordArgumentsDescriptorManager
-                    .getArgumentsDescriptor(keywords.toArray(n -> new String[n]));
+                    .getArgumentsDescriptor(keywords.toArray(StringUtils.EMPTY_STRING_ARRAY));
         } else {
             return EmptyArgumentsDescriptor.INSTANCE;
         }