add unit tests

Author: alai8

operator/src/test/java/oracle/kubernetes/operator/helpers/AdminPodHelperTest.java

@@ -24,6 +24,7 @@
 import io.kubernetes.client.models.V1Pod;
 import io.kubernetes.client.models.V1PodSpec;
 import io.kubernetes.client.models.V1Status;
+import java.lang.reflect.InvocationTargetException;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
@@ -247,6 +248,20 @@ public void whenDomainHasEnvironmentItemsWithVariables_createAdminPodStartupWith
             hasEnvVar("item2", "ADMIN_SERVER is ADMIN_SERVER:7001")));
   }
 
+  @Test
+  public void whenDomainHasEnvironmentItemsWithVariable_createPodShouldNotChangeItsValue()
+      throws NoSuchMethodException, IllegalAccessException, InvocationTargetException {
+    final String ITEM_RAW_VALUE = "find uid1 at $(DOMAIN_HOME)";
+    configureAdminServer().withEnvironmentVariable("item1", ITEM_RAW_VALUE);
+
+    getCreatedPod();
+
+    getConfiguredDomainSpec().getAdminServer().getEnv();
+    assertThat(
+        getConfiguredDomainSpec().getAdminServer().getEnv(),
+        allOf(hasEnvVar("item1", ITEM_RAW_VALUE)));
+  }
+
   @Test
   public void createAdminPodStartupWithNullAdminUsernamePasswordEnvVarsValues() {
     configureAdminServer();

operator/src/test/java/oracle/kubernetes/operator/helpers/JobHelperTest.java

@@ -15,6 +15,8 @@
 import io.kubernetes.client.models.V1JobSpec;
 import io.kubernetes.client.models.V1ObjectMeta;
 import io.kubernetes.client.models.V1SecretReference;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 import java.util.List;
 import oracle.kubernetes.operator.ProcessingConstants;
 import oracle.kubernetes.operator.TuningParameters;
@@ -298,6 +300,30 @@ public void introspectorPodStartupWithNullAdminUsernamePasswordEnvVarValues() {
         allOf(hasEnvVar("ADMIN_USERNAME", null), hasEnvVar("ADMIN_PASSWORD", null)));
   }
 
+  @Test
+  public void whenDomainHasEnvironmentItemsWithVariable_introspectorPodStartupShouldNotChangeIt()
+      throws NoSuchMethodException, IllegalAccessException, InvocationTargetException {
+    DomainPresenceInfo domainPresenceInfo = createDomainPresenceInfo();
+
+    DomainConfigurator domainConfigurator =
+        configureDomain(domainPresenceInfo).withEnvironmentVariable("item1", RAW_VALUE_1);
+
+    Packet packet = new Packet();
+    packet
+        .getComponents()
+        .put(ProcessingConstants.DOMAIN_COMPONENT_NAME, Component.createFor(domainPresenceInfo));
+    DomainIntrospectorJobStepContext domainIntrospectorJobStepContext =
+        new DomainIntrospectorJobStepContext(domainPresenceInfo, packet);
+    V1JobSpec jobSpec =
+        domainIntrospectorJobStepContext.createJobSpec(TuningParameters.getInstance());
+
+    getContainerFromJobSpec(jobSpec, domainPresenceInfo.getDomainUID());
+
+    MatcherAssert.assertThat(
+        getConfiguredDomainSpec(domainConfigurator).getEnv(),
+        allOf(hasEnvVar("item1", RAW_VALUE_1)));
+  }
+
   @Test
   public void verify_introspectorPodSpec_activeDeadlineSeconds_initial_values() {
     DomainPresenceInfo domainPresenceInfo = createDomainPresenceInfo();
@@ -385,4 +411,15 @@ private V1Container getContainerFromJobSpec(V1JobSpec jobSpec, String domainUID)
   static Matcher<Iterable<? super V1EnvVar>> hasEnvVar(String name, String value) {
     return hasItem(new V1EnvVar().name(name).value(value));
   }
+
+  Method getDomainSpec;
+
+  DomainSpec getConfiguredDomainSpec(DomainConfigurator domainConfigurator)
+      throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
+    if (getDomainSpec == null) {
+      getDomainSpec = DomainConfigurator.class.getDeclaredMethod("getDomainSpec");
+      getDomainSpec.setAccessible(true);
+    }
+    return (DomainSpec) getDomainSpec.invoke(domainConfigurator);
+  }
 }

operator/src/test/java/oracle/kubernetes/operator/helpers/ManagedPodHelperTest.java

@@ -164,6 +164,16 @@ public void createManagedPodStartupWithNullAdminUsernamePasswordEnvVarsValues()
         allOf(hasEnvVar("ADMIN_USERNAME", null), hasEnvVar("ADMIN_PASSWORD", null)));
   }
 
+  @Test
+  public void whenPacketHasEnvironmentItemsWithVariable_createManagedPodShouldNotChangeItsValue() {
+    V1EnvVar ENVVAR = toEnvVar(ITEM1, RAW_VALUE_1);
+    testSupport.addToPacket(ProcessingConstants.ENVVARS, Arrays.asList(ENVVAR));
+
+    getCreatedPodSpecContainer();
+
+    assertThat(ENVVAR.getValue(), is(RAW_VALUE_1));
+  }
+
   @Test
   public void whenPacketHasClusterConfig_managedPodHasClusterLabel() {
     testSupport.addToPacket(ProcessingConstants.CLUSTER_NAME, CLUSTER_NAME);

operator/src/test/java/oracle/kubernetes/operator/helpers/PodHelperTestBase.java

@@ -57,6 +57,8 @@
 import io.kubernetes.client.models.V1SecurityContext;
 import io.kubernetes.client.models.V1Volume;
 import io.kubernetes.client.models.V1VolumeMount;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
@@ -153,6 +155,17 @@ DomainConfigurator getConfigurator() {
     return configurator;
   }
 
+  Method getDomainSpec;
+
+  DomainSpec getConfiguredDomainSpec()
+      throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
+    if (getDomainSpec == null) {
+      getDomainSpec = DomainConfigurator.class.getDeclaredMethod("getDomainSpec");
+      getDomainSpec.setAccessible(true);
+    }
+    return (DomainSpec) getDomainSpec.invoke(configurator);
+  }
+
   @Before
   public void setUp() throws Exception {
     mementos.add(