-
Notifications
You must be signed in to change notification settings - Fork 1
Update dependabot settings #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Major version changes are by definition breaking changes and dependabot cannot change the things they break (e.g., the reason PR #398 failed tests). Non-major changes are backwards compatible and safe to update with dependabot. Signed-off-by: Dave Thaler <[email protected]>
WalkthroughConsolidates Dependabot NuGet configuration into a single entry covering multiple directories, adds a rule to ignore semver-major updates, and standardizes scheduling to weekly on Saturday. Removes separate daily entries for /Test and /TransferData. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Scheduler as GitHub Schedule
participant Dependabot as Dependabot
participant Repos as Repo Dirs\n/OrcanodeMonitor, /Test, /TransferData
participant PRs as Pull Requests
Scheduler->>Dependabot: Weekly trigger (Saturday)
Dependabot->>Repos: Scan NuGet dependencies
Note over Dependabot,Repos: Apply ignore rule: skip semver-major updates
Dependabot->>PRs: Create/update PRs for eligible updates
PRs-->>Dependabot: Status feedback (success/fail)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates dependabot configuration to exclude major version updates and consolidate NuGet package monitoring across multiple directories. Major version updates are excluded because they represent breaking changes that dependabot cannot automatically resolve.
- Consolidates three separate NuGet package ecosystem entries into a single entry covering all directories
- Adds ignore rule to exclude major version updates (semver-major) for all dependencies
- Changes update schedule from daily to weekly for NuGet packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
28-30: Rename group for clarity.Minor: the group name
actionsunder the NuGet block can be confusing. Consider a neutral name likenuget-allto avoid implying it relates to GitHub Actions.- groups: - actions: + groups: + nuget-all: patterns: - "*"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/dependabot.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build_windows (Release)
- GitHub Check: build_windows (Debug)
- GitHub Check: Analyze (csharp)
🔇 Additional comments (2)
.github/dependabot.yml (2)
20-23: Use ofdirectorieslooks correct; verify paths.
directoriesis a supported key to apply one config across multiple folders. Ensure these three paths are accurate and that there are no other NuGet update blocks targeting overlapping directories/branches. (docs.github.com)
31-34: Blocking semver-major updates is configured correctly.The
ignorerule withdependency-name: "*"andupdate-types: ["version-update:semver-major"]will suppress PRs for major version bumps while keeping security updates unaffected. This aligns with the PR goal. (docs.github.com)
Major version changes are by definition breaking changes and dependabot cannot change the things they break (e.g., the reason PR #398 failed tests). Non-major changes are backwards compatible and safe to update with dependabot.
Summary by CodeRabbit