Skip to content

Conversation

@dsmurfin
Copy link
Contributor

Exposes framingMode as public on OSCTCPServer and OSCTCPClient to implementors.

This is a useful addition when implementors wish to query existing server or client settings to understand whether the server needs to be reinitialized with new configuration. framingMode is a user space property along with interface, port and host, so should also be visible to implementations.

Copilot AI review requested due to automatic review settings December 29, 2025 11:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes the framingMode property as public on both OSCTCPServer and OSCTCPClient classes, enabling implementors to query the current TCP framing configuration. This is useful for determining whether a server or client needs to be reinitialized with new settings.

Key Changes:

  • Made framingMode property public with documentation on both OSCTCPServer and OSCTCPClient
  • Moved property declaration from internal section to public properties section alongside other configuration properties

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Sources/OSCKit/TCP/Server/OSCTCPServer.swift Moved framingMode property from internal to public section with doc comment
Sources/OSCKit/TCP/Client/OSCTCPClient.swift Moved framingMode property from internal to public section with doc comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@orchetect orchetect self-assigned this Dec 29, 2025
@orchetect
Copy link
Owner

Absolutely - makes sense.

@orchetect orchetect self-requested a review December 29, 2025 21:21
@orchetect
Copy link
Owner

The PR branch doesn't allow maintainer access, so if you can resolve the merge conflicts I can merge this down.

@dsmurfin dsmurfin force-pushed the framing-mode-public branch from b9d4f16 to cad89aa Compare December 31, 2025 11:10
@dsmurfin
Copy link
Contributor Author

The PR branch doesn't allow maintainer access, so if you can resolve the merge conflicts I can merge this down.

Thanks @orchetect that's been rebased and conflicts resolved.

@orchetect orchetect merged commit 3855c3f into orchetect:main Dec 31, 2025
7 checks passed
@dsmurfin dsmurfin deleted the framing-mode-public branch January 1, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants