Skip to content

Conversation

@eltouma
Copy link
Contributor

@eltouma eltouma commented Feb 10, 2026

This change builds on the fix introduced by @xJuvi in #934

TomSelect renders a focusable <input> inside .ts-control to implement the placeholder/search UI:

const placeholder = getDom('<input class="items-placeholder" tabindex="-1" />') as HTMLInputElement;
placeholder.placeholder = self.settings.placeholder || '';
self.control.append(placeholder);

Even when the source is correctly labelled, its aria-label is not always propagated to that generated input. As a result, accessibility checkers may report a “Missing form label” warning. This patch ensures the generated input inherits the original aria-label, keeping the enhanced control accessible while preserving existing behavior.

@xJuvi
Copy link
Contributor

xJuvi commented Feb 10, 2026

It would also be great if you could add a description to your pull request. This should include what you changed and why.
Thank you very much for your contribution!

@NicolasCARPi
Copy link
Collaborator

@xJuvi new commit has been pushed with code in the right place, we'd appreciate your review :)

@NicolasCARPi NicolasCARPi requested a review from xJuvi February 10, 2026 17:02
Copy link
Contributor

@xJuvi xJuvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes.

@NicolasCARPi NicolasCARPi merged commit 0652ef6 into orchidjs:master Feb 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants