-
-
Notifications
You must be signed in to change notification settings - Fork 158
bug/minor: WCAG: fix 'Missing form label' #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/minor: WCAG: fix 'Missing form label' #986
Conversation
|
It would also be great if you could add a description to your pull request. This should include what you changed and why. |
|
@xJuvi new commit has been pushed with code in the right place, we'd appreciate your review :) |
xJuvi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the changes.
This change builds on the fix introduced by @xJuvi in #934
TomSelect renders a focusable
<input>inside.ts-controlto implement the placeholder/search UI:Even when the source is correctly labelled, its aria-label is not always propagated to that generated input. As a result, accessibility checkers may report a “Missing form label” warning. This patch ensures the generated input inherits the original aria-label, keeping the enhanced control accessible while preserving existing behavior.