feat(minor): [sc-28167] move Transferable.swift protocols to DistributedABI module#124
Open
tayloraswift wants to merge 1 commit intomainfrom
Open
Conversation
Author
|
lint failures almost certainly predate PR |
Contributor
|
Looking to history it was originally split similar to this, but then we merged this back for simplicity: https://github.com/ordo-one/package-distributed-system-conformance One question although. If I do some 3rd party application and link distributed system (statically). I guess this change will change the way how I ship my app. Since before I get self sufficient binary, but now this dependency is built as separate library and should be shipped together with my app. Feels like major break. Do I miss something? |
Author
|
i believe (but am not 100% sure) that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
we can use
@_exportedto make this change transparent to clientsthis module is set to
-enable-library-evolutionwhen built by itself, but this module only contains protocols so it shouldn’t affect userseven if we don’t end up vending
DistributedABIas an xcframework, this would still be a beneficial architectural change in its own rightHow Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Minimal checklist:
DocCcode-level documentation for any public interfaces exported by the package