Skip to content

fix(patch): [sc-13510] Remove dependency on latency timer.#93

Merged
ser-0xff merged 2 commits intomainfrom
chore/sc-13510/ds-adopt-for-swift-6
Feb 11, 2025
Merged

fix(patch): [sc-13510] Remove dependency on latency timer.#93
ser-0xff merged 2 commits intomainfrom
chore/sc-13510/ds-adopt-for-swift-6

Conversation

@ser-0xff
Copy link
Contributor

Description

Include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (0cb3838) to head (88e4b67).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   73.97%   73.88%   -0.09%     
==========================================
  Files          30       30              
  Lines        5690     5690              
==========================================
- Hits         4209     4204       -5     
- Misses       1481     1486       +5     

see 2 files with indirect coverage changes

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb3838...88e4b67. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

@blindspotbounty
Copy link
Contributor

Should remove from Package.swift as well?

@ser-0xff
Copy link
Contributor Author

Yes, fixed.

@blindspotbounty
Copy link
Contributor

should remove product dependencies as well?
like those:
https://github.com/ordo-one/package-distributed-system/blob/main/Package.swift#L122

@ser-0xff ser-0xff merged commit 15d0a15 into main Feb 11, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants