feat(gorelease): Fix flaky aws-nuke-v2 releases#10
Merged
corybekk merged 1 commit intooreilly-mainfrom Mar 27, 2025
Merged
Conversation
corybekk
force-pushed
the
CL-1167-fix-releases
branch
from
997b461 to
83a1b4b
Compare
corybekk
changed the title
gsoria
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
It is kind of confusing to me that the links of your PR description points to the cloudformation stack fixes jobs which I retried manually. But I think you have a point that the action shouldn't been triggered by the merge commit. I think it is fine to try this! Thanks @corybekk !
danarbaugh
reviewed
Mar 27, 2025
Member
danarbaugh
left a comment
danarbaugh
left a comment
There was a problem hiding this comment.
That's a great find, Cory! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the failed release, I noticed that the release was being executed twice. One was triggered automatically when a new tag was pushed (GoReleaser 25) and the other was triggered manually (GoReleaser 26). I removed the tag trigger from the workflow so only published releases work.
GoReleaser 25 v3.48.2-orm succeeded: link
- Triggered via push
When you create a tag like v3.48.2-orm, GitHub pushes that tag.
This immediately triggers the workflow before the release is officially published.
GoReleaser runs and tries to create a release.
GoReleaser 26 v3.48.2-orm failed : link
- Triggered via release
When you later publish a release using GitHub’s UI (or an automated process), GitHub fires another event: "release published".
This again triggers the workflow.
GoReleaser sees the same tag and release name and tries to create it again, leading to a failure due to duplication.