Skip to content

Conversation

corybekk
Copy link

@corybekk corybekk commented Aug 7, 2024

Description

This PR adds a new module for cleaning up kinesis signaling channels.

Testing

  1. Create the signaling channel
    aws kinesisvideo create-signaling-channel --channel-name test-channel

  2. Run aws-nuke and include the KinesisSignalingChannels module

aws-nuke version unknown - unknown - unknown

Do you really want to nuke the account with the ID 12345 and the alias 'alias-12345'?
Waiting 3s before continuing.
us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:12345:channel/test-channel/12345 - would remove
us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:12345:channel/test-channel-234234/12345 - would remove
Scan complete: 2 total, 2 nukeable, 0 filtered.

Do you really want to nuke these resources on the account with the ID 12345 and the alias 'alias-384736907310'?
Waiting 3s before continuing.
us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:12345:channel/test-channel/123456 - triggered remove
us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:12345:channel/test-channel-234234/12345 - triggered remove
	
Removal requested: 2 waiting, 0 failed, 0 skipped, 0 finished
  1. Verify the resources have been deleted
    aws kinesisvideo list-signaling-channels

@corybekk corybekk marked this pull request as ready for review August 7, 2024 17:42
Copy link
Member

@danarbaugh danarbaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cory. I tried this out on an account from the dev OU and saw the following expected output:

us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:384736907310:channel/test-channel/1723069332577 - removed

Please don't forget to create a companion PR in cl-cloud-user-creator to add this to settings. Also, I think you may have opened draft PR #31 by mistake.

Copy link

@swhite-oreilly swhite-oreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, cleaned up as expected. Thanks Cory.

@corybekk
Copy link
Author

corybekk commented Aug 8, 2024

Thanks Cory. I tried this out on an account from the dev OU and saw the following expected output:

us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:384736907310:channel/test-channel/1723069332577 - removed

Please don't forget to create a companion PR in cl-cloud-user-creator to add this to settings. Also, I think you may have opened draft PR #31 by mistake.

thanks Dan. Added: https://github.com/oreillymedia/cl-cloud-user-creator/pull/298

@corybekk
Copy link
Author

corybekk commented Aug 8, 2024

Thanks Cory. I tried this out on an account from the dev OU and saw the following expected output:

us-east-1 - KinesisSignalingChannels - arn:aws:kinesisvideo:us-east-1:384736907310:channel/test-channel/1723069332577 - removed

Please don't forget to create a companion PR in cl-cloud-user-creator to add this to settings. Also, I think you may have opened draft PR #31 by mistake.

Thanks Dan, that was me branching off of main instead of oreilly-main. I will delete it.

@corybekk corybekk merged commit b1363ac into oreilly-main Aug 8, 2024
1 check passed
corybekk pushed a commit that referenced this pull request Nov 6, 2024
* fix(docker): entrypoint on Dockerfile

* docs: improve readme default docs

* docs(readme): improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants