This repository was archived by the owner on Feb 27, 2025. It is now read-only.
fix: change package cdn from unpkg to jsdelivr #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, but I am wondering if we should have a ticket to deprecate this library. The MSW stuff seems to better fit the same purpose, and I'm not sure how many apps are actively using this.
Edit: I just searched, and only two active repos reference the cypress commands for playback (including this one): https://github.com/search?q=org%3Aoreillymedia+%40oreillymedia%2Fcypress-playback%2FaddCommands&type=code
carpie
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running this sandbox does not currently work as the
@mui/materialpackage is not found. It does not look like unpkg is actively supported any longer, so switching to jsdelivr insteadChecklist