Closed
Conversation
strump
commented
Dec 8, 2025
Comment on lines
-143
to
-145
| lang = formatter.determine_language_given_path(str(item)) | ||
| if not lang: | ||
| continue |
Author
There was a problem hiding this comment.
This is how old version checks if language should be update.
It iterates over folders and tries to infere language code from directory path.
strump
commented
Dec 8, 2025
Comment on lines
+123
to
+126
| file_path = lang_path / file_name | ||
| if not file_path.exists() and not create_folders: | ||
| # Don't create file for 'lang'. Only update existing files. | ||
| continue |
Author
There was a problem hiding this comment.
And now Twine checks actual file before generating language (if --create-folders flag disabled).
Signed-off-by: S. Kozyr <s.trump@gmail.com>
strump
force-pushed
the
fix-empty-folder-for-langs
branch
from
25426cf to
aa71351
Compare
Member
|
As we discussed, there is no need to merge this change now, because the behavior in master branch is more flexible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Twine generates files it ignores empty folders for langs.