Skip to content

fix(ui): don't exit when typing 'q' in hexdump search and jump#132

Merged
orhun merged 1 commit intoorhun:mainfrom
MykBamberg:main
Apr 16, 2025
Merged

fix(ui): don't exit when typing 'q' in hexdump search and jump#132
orhun merged 1 commit intoorhun:mainfrom
MykBamberg:main

Conversation

@MykBamberg
Copy link
Contributor

Description of change

The effect of the change was manually tested.

@MykBamberg MykBamberg requested a review from orhun as a code owner April 14, 2025 05:38
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 3.29%. Comparing base (d3b90ad) to head (ea55056).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tui/state.rs 0.00% 14 Missing ⚠️
src/tui/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #132      +/-   ##
========================================
- Coverage   3.30%   3.29%   -0.01%     
========================================
  Files         19      19              
  Lines       2426    2437      +11     
========================================
  Hits          80      80              
- Misses      2346    2357      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@orhun orhun merged commit 338d919 into orhun:main Apr 16, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants