Fixed a couple of small issues relating to the handling of backup log entries. #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added a filter to limit the total number of entries that are loaded and displayed from the backup log to prevent a very large number of log entries from slowing down the entire studio app.
odysseaspenta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue reported in issue #588 where opening the database backups view generates an error in the logs.
It also fixes issue #589 where too many backup log entries can overwhelm the client and slow down the entire studio app.
The fix for this issue involves adding a filter to limit the total number of entries that are loaded and displayed from the backup log to prevent a very large number of log entries from slowing down the entire studio app.
This is a quick fix. A better fix would involve caching the backup log events on the client so that they are not constantly reloaded.