Fix for #88 - add full support for class.update #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated class.update to support current spec with the exception of CLUSTERSELECTION and CUSTOM which seem to have other issues currently. Added unit tests for new updates to class.update.
|
+1 |
Nice option to remove newlines from functions during createFn to make it easier maintaining the functions.
Nice option to remove newlines from functions during createFn to make it easier maintaining the functions.
Remove newlines for createFn
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated class.update to support current spec with the exception of
CLUSTERSELECTION and CUSTOM which seem to have other issues currently.
Added unit tests for new updates to class.update.