feat: support themes in subdirectories#223
Open
tmchow wants to merge 1 commit intooriginalankur:mainfrom
Open
Conversation
Replace os.listdir() with os.walk() in get_available_themes() so theme JSON files in nested directories are discovered. Theme names use forward-slash relative paths (e.g. "custom/my_theme"). The list-themes output groups nested themes by directory. Fixes originalankur#157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
os.listdir()withos.walk()inget_available_themes()so theme JSON files in nested directories underthemes/are discovered. Theme names use forward-slash relative paths (e.g.custom/my_themeforthemes/custom/my_theme.json).PS - Love this project!
Why this matters
Reported in #157. Users with many themes want to organize them into subdirectories (
original/,custom/, etc.) but the current code only scans the top-levelthemes/directory.Changes
get_available_themes()(line 161): usesos.walk()to recursively find.jsonfiles. Returns theme names as relative paths with forward slashes for cross-platform consistency. Flat themes sort first, then nested themes alphabetically.list_themes()(line 843): groups nested themes by directory with[group]headers for readability. Flat themes display first, unchanged.load_theme(): no changes needed.os.path.join(THEMES_DIR, f"{theme_name}.json")already resolves paths containing subdirectory prefixes correctly.Testing
Fixes #157
This contribution was developed with AI assistance (Codex).