Skip to content

Updated Wycheproof ML-KEM testvectors#583

Merged
brycx merged 2 commits intomasterfrom
new-mlkem-wycheproof
Jan 8, 2026
Merged

Updated Wycheproof ML-KEM testvectors#583
brycx merged 2 commits intomasterfrom
new-mlkem-wycheproof

Conversation

@brycx
Copy link
Copy Markdown
Member

@brycx brycx commented Jan 8, 2026

No description provided.

@brycx brycx added the testing All testing, except for fuzzing related label Jan 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 96.98795% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.07%. Comparing base (1684c1b) to head (191d8f9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tests/kem/mlkem/c2sp_wycheproof.rs 96.98% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   99.10%   99.07%   -0.04%     
==========================================
  Files         108      108              
  Lines       19705    20002     +297     
==========================================
+ Hits        19529    19817     +288     
- Misses        176      185       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brycx
Copy link
Copy Markdown
Member Author

brycx commented Jan 8, 2026

Lines missing coverage are not important, as they're panics in the KAT parsing intended to alert us in the future, if the vectors are updated and/or comments/flags are changed/added. Those are used to make testing decision on.

@brycx brycx merged commit 9db75d8 into master Jan 8, 2026
27 of 29 checks passed
@brycx brycx deleted the new-mlkem-wycheproof branch January 8, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing All testing, except for fuzzing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant