Increase allowed BCrypt rounds from 18 to 32#119
Merged
Joannis merged 1 commit intoorlandos-nl:mainfrom Jan 8, 2026
Merged
Conversation
Member
|
Thanks for the PR! This code stems from my initial work in 2017 haha. |
Contributor
Author
|
Ah, that explains the lower number of rounds 😄 Do you know how to fix the failing check? |
Member
|
I do! Curious it got merged into main, that's API that didn't exist until Swift 5.10 or 6.2 I'll fix it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this great package!
I noticed that when generating an OpenSSH key with a passphrase on my Mac, the default amount of iterations is 24:
However, Citadel doesn't support this key because in OpenSSHKey.swift the limit is set to 18 rounds, even though the underlying C code can handle more. Therefore I suggest increasing the limit to 32.