Add unit test for lastKeySearchHint inheritance in nested decoders#53
Merged
Joannis merged 3 commits intojo/key-lookup-optimizationsfrom Jan 15, 2026
Merged
Add unit test for lastKeySearchHint inheritance in nested decoders#53Joannis merged 3 commits intojo/key-lookup-optimizationsfrom
Joannis merged 3 commits intojo/key-lookup-optimizationsfrom
Conversation
Co-authored-by: Joannis <1951674+Joannis@users.noreply.github.com>
Co-authored-by: Joannis <1951674+Joannis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit test for object key lookup optimization
Add unit test for lastKeySearchHint inheritance in nested decoders
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates potential optimization inefficiency where
lastKeySearchHintis not reset when creating subDecoders, causing inherited hints to point to invalid offsets in child contexts.Test Coverage
Behavior Verified
The test confirms current implementation handles nested objects correctly despite the issue. Wraparound logic in
valueOffset(forKey:convertingSnakeCasing:in:hint:)prevents incorrect results but forces unnecessary wraparound searches when hints reference parent index space.Child decoders should initialize with
lastKeySearchHint = Constants.firstArrayObjectChildOffsetrather than inheriting parent's offset.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.