feat(angular): add angular httpResource support by the-ult · Pull Request #2923 · orval-labs/orval

the-ult · 2026-02-08T13:58:42Z

Summary

This PR introduces Angular httpResource service generation (signal-first APIs) and expands the Angular sample app to showcase both httpResource and httpResource + Zod flows alongside the existing HttpClient output.

Related issue

Closes Support Angular httpResource API #2316
Reference comment: Support Angular httpResource API #2316 (comment)

Primary focus — httpResource generation (packages/angular + core)

Adds a dedicated httpResource generator that emits signal-first resource functions for retrieval operations, while keeping HttpClient service methods for mutations.
Supports per-operation overrides via override.operations.<operationId>.angular.client to force httpResource, httpClient, or both.
Introduces route registry + shared return type registries to ensure correct resource generation and type aliases.
Generates ResourceState utilities (ResourceState<T> and toResourceState) for ergonomic status handling in signal-based flows.
Adds content-type-aware factories for resource outputs (httpResource, .text, .arrayBuffer, .blob).
Adds Zod runtime validation for httpResource JSON responses when schemas.type: 'zod' (with an opt-out via runtimeValidation: false).
Adds a both-mode extra file (*.resource.ts) to emit resources alongside HttpClient output.

Expanded Angular sample app (samples/angular-app)

Adds two new routes/pages:
- /http-resource — demonstrates signal-first httpResource usage.
- /http-resource-zod — demonstrates httpResource with Zod runtime validation.
Updates orval.config.ts to generate new http-resource and http-resource-zod outputs, including mock support.
Adds sample-generated client artifacts for the new outputs to make the demo self-contained.

Docs & guidance

Updates the Angular guide to document httpResource output, configuration, and Zod runtime validation behaviors.
Clarifies the experimental status of httpResource (Angular v19.2+).

Other improvements / related fixes

Normalizes Angular override defaults in config parsing (runtimeValidation, client, provideIn).
Extends Angular fixtures in tests to cover httpResource and Zod validation toggles.
Adds extensive generator tests for http-resource and http-client outputs.
Lint generated fixtures: Adds lint:generated (root script + Turbo task + tests workspace script) to validate generated outputs in generated, which are updated by this PR’s new Angular httpResource fixtures.

Angular Query compatibility fix

Aligns generated Angular Query mutation onSuccess callbacks with the current TanStack Query signature (adds context argument).
Required because this PR updates the Angular catalogs and sample outputs; without it, the Angular Query samples fail to typecheck.

Other unrelated changes

MSW mock generator refinements (response content-type handling for text/plain and header outputs).
Miscellaneous sample/config updates (Angular/Next sample package updates and lint config alignment).

Tests

Added/updated generator tests for packages/angular/src/http-resource.ts and packages/angular/src/http-client.ts.

Introduce a dedicated httpResource client generator with route tracking\nand resource return-type registries. Add shared dependency/templates utilities, new tests, and expose the\nangular client mode (httpClient/httpResource/both) through config\nnormalization and generator selection.

Split generated API outputs into http-client and http-resource targets\nwith updated MSW mocks and sample pages. Add routing and UI for the new httpResource screen plus the versioned\npath transformer used by both outputs.

Add lint:generated task wiring across root and tests, and update\nturbo pipeline + README guidance. Introduce ESLint configs for Angular/Next samples and refresh Angular\ncatalog + dependencies to include Angular ESLint support.

- add url-only httpResource generation and zod parse options - normalize angular runtimeValidation and update config/types/tests - document httpResource output and add zod sample pages/output

- precompute delay expressions to handle function delays safely - expand MSW tests and update angular sample mocks - expose MSW_DELAY in turbo global env

- resolve schema path when schemas is an object - avoid cleaning the wrong directory during generation

the-ult · 2026-02-08T14:00:34Z

Initial setup to add httpResource functionality.
Even thought httpResource is still experimental. It is already used in many production environments. (and it will probably be in Developer Preview (or even stable) in the next release (v22) in may.
And even when API's change, that will be easy to fix/adjust to.

Copilot

Pull request overview

Adds first-class Angular httpResource (signal-first) client generation to Orval, plus sample app and documentation updates to demonstrate HttpClient, httpResource, and httpResource + Zod flows.

Changes:

Implement Angular httpResource generator (including “both” mode extra *.resource.ts output) with route/return-type registries and ResourceState helpers.
Extend config normalization + core types to support override.angular.client and override.angular.runtimeValidation, and improve schema-cleaning for object-form schemas.
Update samples/docs/tooling (Angular sample routes, generated artifacts, MSW tweaks, ESLint/turbo scripts, dependency catalogs).

Reviewed changes

Copilot reviewed 60 out of 63 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
turbo.json	Adds MSW_DELAY to global env and introduces `lint:generated` task.
tests/package.json	Adds `lint:generated` script for generated fixtures.
tests/configs/angular.config.ts	Adds Angular test outputs for `httpResource` + Zod (and validation-disabled) variants.
samples/next-app-with-fetch/package.json	Switches lint to eslint and adds flat-config dependencies.
samples/next-app-with-fetch/eslint.config.mjs	Adds ESLint flat config for Next sample.
samples/angular-query/package.json	Adds Angular ESLint + ESLint v9 toolchain deps.
samples/angular-query/eslint.config.mjs	Adds ESLint flat config for Angular Query sample.
samples/angular-query/angular.json	Adds `@angular-eslint` lint builder target.
samples/angular-app/src/orval/transformer/add-version.js	Adds OpenAPI transformer to prefix versioned routes.
samples/angular-app/src/orval/node.ts	Aggregates multiple generated MSW mock bundles for node tests.
samples/angular-app/src/orval/browser.ts	Aggregates multiple generated MSW mock bundles for browser worker.
samples/angular-app/src/app/http-resource.page.ts	Adds sample page demonstrating `httpResource` usage.
samples/angular-app/src/app/http-resource-zod.page.ts	Adds sample page demonstrating `httpResource` + Zod validation.
samples/angular-app/src/app/http-resource-zod.page.spec.ts	Adds basic component tests for the Zod resource page.
samples/angular-app/src/app/http-client.page.ts	Adds sample page demonstrating `HttpClient` output + content-type overloads.
samples/angular-app/src/app/app.ts	Refactors root component to a router-based sample navigation.
samples/angular-app/src/app/app.spec.ts	Updates root component test to account for router navigation links.
samples/angular-app/src/app/app.routes.ts	Adds routes for HttpClient / httpResource / httpResource+Zod demo pages.
samples/angular-app/src/app/app.config.ts	Adds router provider to standalone app config.
samples/angular-app/src/api/model-zod/searchPetsParams.zod.ts	Adds generated Zod schema artifacts for sample.
samples/angular-app/src/api/model-zod/pets.zod.ts	Adds generated Zod schema artifacts for sample.
samples/angular-app/src/api/model-zod/pet.zod.ts	Adds generated Zod schema artifacts for sample.
samples/angular-app/src/api/model-zod/listPetsParams.zod.ts	Adds generated Zod schema artifacts for sample.
samples/angular-app/src/api/model-zod/index.zod.ts	Adds generated Zod barrel for sample.
samples/angular-app/src/api/model-zod/error.zod.ts	Adds generated Zod schema artifacts for sample.
samples/angular-app/src/api/model-zod/createPetsBody.zod.ts	Adds generated Zod schema artifacts for sample.
samples/angular-app/src/api/http-resource/pets/pets.service.ts	Adds generated `httpResource` endpoints + mutation service + ResourceState utilities.
samples/angular-app/src/api/http-resource/pets/pets.msw.ts	Adds generated MSW mocks for `httpResource` output.
samples/angular-app/src/api/http-resource/index.msw.ts	Adds MSW index export for `httpResource` mocks.
samples/angular-app/src/api/http-resource-zod/pets/pets.service.ts	Adds generated `httpResource` endpoints with Zod parsing + service/utilities.
samples/angular-app/src/api/http-resource-zod/pets/pets.msw.ts	Adds generated MSW mocks for `httpResource + zod` output.
samples/angular-app/src/api/http-resource-zod/index.msw.ts	Adds MSW index export for `httpResource + zod` mocks.
samples/angular-app/src/api/http-client/pets/pets.service.ts	Updates generated HttpClient options typing (adds `referrerPolicy`).
samples/angular-app/src/api/http-client/pets/pets.msw.ts	Adds generated MSW mocks for `http-client` output.
samples/angular-app/src/api/http-client/index.msw.ts	Adds MSW index export for `http-client` mocks.
samples/angular-app/package.json	Adds Zod + ESLint toolchain updates for the Angular sample.
samples/angular-app/orval.config.ts	Adds multiple outputs (http-client, http-resource, http-resource-zod) + MSW mock config.
samples/angular-app/eslint.config.mjs	Adds ESLint flat config for Angular sample.
samples/angular-app/angular.json	Adds `@angular-eslint` lint builder target.
packages/orval/src/utils/options.ts	Normalizes Angular defaults for `client` and `runtimeValidation` (global + per-operation).
packages/orval/src/generate-spec.ts	Fixes cleaning when `output.schemas` is object form (`{ type, path }`).
packages/orval/src/client.ts	Plumbs normalized Angular override options into `@orval/angular` builder and adjusts mock typing.
packages/mock/src/msw/index.ts	Adjusts MSW delay expression emission (function delays now stringified + executed).
packages/mock/src/msw/index.test.ts	Expands MSW generator tests and updates mock option typing usage.
packages/core/src/types.ts	Adds Angular override types (`client`, `runtimeValidation`) and introduces `NormalizedAngularOptions`.
packages/angular/vitest.config.ts	Adds vitest config scaffold for Angular package tests.
packages/angular/src/utils.ts	Adds shared helpers (title generation, registries, retrieval/mutation heuristic, default content-type selection).
packages/angular/src/utils.test.ts	Adds tests for Angular utility helpers.
packages/angular/src/types.ts	Extracts reusable code templates for generated Angular client types.
packages/angular/src/types.test.ts	Adds conformance tests ensuring generated HttpClientOptions stays aligned with Angular API.
packages/angular/src/index.ts	Refactors Angular client entry to support `httpClient`, `httpResource`, and `both` builders.
packages/angular/src/index.test.ts	Adds tests ensuring builder selection behaves as expected.
packages/angular/src/http-resource.ts	Introduces `httpResource` generator with registries, parsing, factories, and extra-file support.
packages/angular/src/http-resource.test.ts	Adds extensive tests for `httpResource` generation behavior.
packages/angular/src/http-client.ts	Refactors HttpClient generator into its own module and shares utilities.
packages/angular/src/http-client.test.ts	Adds extensive tests for HttpClient generation behavior.
packages/angular/src/constants.ts	Centralizes Angular dependency definitions for HttpClient and httpResource modes.
packages/angular/README.md	Updates Angular package README formatting/content.
package.json	Adds root `lint:generated` turbo script.
docs/content/docs/guides/angular.mdx	Documents `httpResource` output and Zod runtime validation options.
README.md	Documents new lint scripts and updated dev workflow steps.
.yarnrc.yml	Updates Angular catalog versions and adds `zod` to catalog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-08T14:05:22Z

packages/orval/src/client.ts

@@ -57,10 +65,6 @@ const getGeneratorClient = (
    ? outputClient(GENERATOR_CLIENT)
    : GENERATOR_CLIENT[outputClient];



getGeneratorClient no longer throws when an unknown outputClient is provided, so generator can be undefined and cause less actionable runtime errors later (e.g., when destructuring header/footer/client). Reintroduce an explicit guard that throws a clear error when the client key is not found (including the provided value).

Suggested change

if (!generator) {

throw new Error(

`Unknown output client provided to getGeneratorClient: ${String(outputClient)}`,

);

}

Copilot · 2026-02-08T14:05:23Z

packages/angular/src/http-resource.ts

+  if (isResponseArrayBuffer(contentType)) return 'httpResource.arrayBuffer';
+  if (isResponseBlob(contentType, response.isBlob)) return 'httpResource.blob';


getHttpResourceFactory checks for application/octet-stream/PDF (arrayBuffer) before honoring response.isBlob. This can produce httpResource.arrayBuffer factories for endpoints that are modeled as Blob, leading to type/runtime mismatches in generated clients. Consider prioritizing response.isBlob (or the Blob return type) over the arrayBuffer heuristic, or otherwise ensure the factory choice and generated return type stay aligned.

Suggested change

if (isResponseArrayBuffer(contentType)) return 'httpResource.arrayBuffer';

if (isResponseBlob(contentType, response.isBlob)) return 'httpResource.blob';

if (isResponseBlob(contentType, response.isBlob)) return 'httpResource.blob';

if (isResponseArrayBuffer(contentType)) return 'httpResource.arrayBuffer';

Copilot · 2026-02-08T14:05:23Z

samples/angular-app/src/api/http-resource/pets/pets.service.ts

+export function downloadFileResource(
+  petId: Signal<number>,
+  version?: Signal<number>,
+): HttpResourceRef<Blob | undefined> {
+  return httpResource.arrayBuffer<Blob>(
+    () => `/v${version?.() ?? 1}/pet/${petId()}/downloadImage`,
+  );


downloadFileResource returns HttpResourceRef<Blob | undefined> but uses httpResource.arrayBuffer<Blob>(...). arrayBuffer resources yield ArrayBuffer data, so this is a type/runtime mismatch. Use the blob factory for Blob responses, or change the return type to ArrayBuffer (and let consumers convert to Blob if needed).

Copilot · 2026-02-08T14:05:23Z

samples/angular-app/src/api/http-resource-zod/pets/pets.service.ts

+export function downloadFileResource(
+  petId: Signal<number>,
+  version?: Signal<number>,
+): HttpResourceRef<Blob | undefined> {
+  return httpResource.arrayBuffer<Blob>(
+    () => `/v${version?.() ?? 1}/pet/${petId()}/downloadImage`,
+  );


downloadFileResource returns HttpResourceRef<Blob | undefined> but uses httpResource.arrayBuffer<Blob>(...). arrayBuffer resources yield ArrayBuffer data, so this is a type/runtime mismatch. Use the blob factory for Blob responses, or change the return type to ArrayBuffer (and let consumers convert to Blob if needed).

Copilot · 2026-02-08T14:05:23Z

samples/angular-app/src/api/http-resource-zod/pets/pets.msw.ts

+      return new HttpResponse(
+        overrideResponse !== undefined
+          ? typeof overrideResponse === 'function'
+            ? await overrideResponse(info)
+            : overrideResponse
+          : getShowPetByIdResponseMock(),
+        { status: 200, headers: { 'Content-Type': 'text/plain' } },
+      );


This handler sets Content-Type: text/plain but may return a Pet object (non-string) when overrideResponse is a Pet or when using the default mock. That produces an invalid/incorrect response body for a text response. Ensure the generated handler serializes non-string values appropriately (or only treats the response as text when the response body type is actually string).

Copilot · 2026-02-08T14:05:24Z

samples/angular-app/src/api/http-resource/pets/pets.msw.ts

+      return new HttpResponse(
+        overrideResponse !== undefined
+          ? typeof overrideResponse === 'function'
+            ? await overrideResponse(info)
+            : overrideResponse
+          : getShowPetByIdResponseMock(),
+        { status: 200, headers: { 'Content-Type': 'text/plain' } },
+      );


This handler sets Content-Type: text/plain but may return a Pet object (non-string) when overrideResponse is a Pet or when using the default mock. That produces an invalid/incorrect response body for a text response. Ensure the generated handler serializes non-string values appropriately (or only treats the response as text when the response body type is actually string).

Copilot · 2026-02-08T14:05:24Z

samples/angular-app/src/api/http-resource/pets/pets.msw.ts

+      return new HttpResponse(
+        JSON.stringify(
+          overrideResponse !== undefined
+            ? typeof overrideResponse === 'function'
+              ? await overrideResponse(info)
+              : overrideResponse
+            : getDownloadFileResponseMock(),
+        ),
+        { status: 200, headers: { 'Content-Type': 'application/json' } },
+      );


This handler JSON-stringifies a Blob response and sets Content-Type: application/json, which breaks binary downloads and does not match the declared Blob return type. The generated handler should return the Blob body directly (or use MSW’s binary helpers) and set an appropriate binary content-type (e.g., octet-stream) based on the operation’s response content-type.

Copilot · 2026-02-08T14:05:24Z

samples/angular-app/src/api/http-resource-zod/pets/pets.msw.ts

+      return new HttpResponse(
+        JSON.stringify(
+          overrideResponse !== undefined
+            ? typeof overrideResponse === 'function'
+              ? await overrideResponse(info)
+              : overrideResponse
+            : getDownloadFileResponseMock(),
+        ),
+        { status: 200, headers: { 'Content-Type': 'application/json' } },
+      );


This handler JSON-stringifies a Blob response and sets Content-Type: application/json, which breaks binary downloads and does not match the declared Blob return type. The generated handler should return the Blob body directly (or use MSW’s binary helpers) and set an appropriate binary content-type (e.g., octet-stream) based on the operation’s response content-type.

Copilot · 2026-02-08T14:05:24Z

packages/angular/src/http-resource.ts

+import {
+  type ClientBuilder,
+  type ClientDependenciesBuilder,
+  type ClientExtraFilesBuilder,
+  type ClientFooterBuilder,
+  type ClientHeaderBuilder,
+  type ContextSpec,
+  conventionName,
+  generateDependencyImports,
+  generateFormDataAndUrlEncodedFunction,
+  generateMutatorImports,
+  generateVerbImports,
+  type GeneratorDependency,
+  type GeneratorImport,
+  type GeneratorMutator,
+  type GeneratorOptions,
+  type GeneratorVerbOptions,
+  getFileInfo,
+  getFullRoute,
+  GetterPropType,
+  isObject,
+  isSyntheticDefaultImportsAllow,
+  jsDoc,
+  type NormalizedOutputOptions,
+  type OpenApiInfoObject,
+  pascal,
+  type ResReqTypesValue,
+  toObjectString,
+  upath,
+} from '@orval/core';


Unused import generateVerbImports.

ScriptType · 2026-02-08T14:12:57Z

First absolutely stunning pr 👍 .
@melloware I will look deeper into it.

@the-ult without me having a deeper knowledge at the moment it would be nice when you address the ai issues, (Even when you write a comment that the ai is stupid there would be fine )

the-ult · 2026-02-08T14:24:20Z

Thanks :-)

I wil fix/handle the CoPilot comments in the next days.

Introduce a dedicated httpResource client generator with route tracking\nand resource return-type registries. Add shared dependency/templates utilities, new tests, and expose the\nangular client mode (httpClient/httpResource/both) through config\nnormalization and generator selection.

Split generated API outputs into http-client and http-resource targets\nwith updated MSW mocks and sample pages. Add routing and UI for the new httpResource screen plus the versioned\npath transformer used by both outputs.

Add lint:generated task wiring across root and tests, and update\nturbo pipeline + README guidance. Introduce ESLint configs for Angular/Next samples and refresh Angular\ncatalog + dependencies to include Angular ESLint support.

- add url-only httpResource generation and zod parse options - normalize angular runtimeValidation and update config/types/tests - document httpResource output and add zod sample pages/output

- precompute delay expressions to handle function delays safely - expand MSW tests and update angular sample mocks - expose MSW_DELAY in turbo global env

- resolve schema path when schemas is an object - avoid cleaning the wrong directory during generation

melloware · 2026-02-08T14:51:39Z

I just rebased your branch and will run the tests

- Restore defensive guard in getGeneratorClient for custom OutputClientFunc - Fix blob/arrayBuffer check ordering in httpResource factory - Remove unused generateVerbImports import - Remove unnecessary nullish coalescing on response.definition.success - Use String.raw template literals for regex patterns - Regenerate samples with corrected blob resource output

…tp-resource' into feat/add-angular-http-resource

ScriptType · 2026-02-08T19:05:56Z

Hmm, i get the feeling this pr could be split up in to multiple pr´s. What are your thoughts @the-ult ?

Split generated API outputs into http-client and http-resource targets\nwith updated MSW mocks and sample pages. Add routing and UI for the new httpResource screen plus the versioned\npath transformer used by both outputs.

- add url-only httpResource generation and zod parse options - normalize angular runtimeValidation and update config/types/tests - document httpResource output and add zod sample pages/output

- Restore defensive guard in getGeneratorClient for custom OutputClientFunc - Fix blob/arrayBuffer check ordering in httpResource factory - Remove unused generateVerbImports import - Remove unnecessary nullish coalescing on response.definition.success - Use String.raw template literals for regex patterns - Regenerate samples with corrected blob resource output

Revert back to not using yarn catalogs. But had to update some packages, due to yarn warnings.

packages/hono/package.json

Use next lint instead of eslint

revert scope creep, as much as possible

TanStack Query v5 mutation callbacks now require the extra context argument, which breaks generated Angular Query clients/tests after the catalog bump in this PR. This change updates the generator and regenerated samples to pass the 4th argument and keeps CI green in the same PR because the dependency upgrade and sample refresh already happen here.

Will be done in separate PR

…tp-resource

Copilot

Pull request overview

Copilot reviewed 62 out of 65 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T20:34:17Z

packages/orval/src/utils/package-json.test.ts

      vi.mocked(findUp).mockImplementation((name) => {
        if (name === 'pnpm-workspace.yaml') return;
        if (name === '.yarnrc.yml') return;
+      vi.mocked(findUp).mockImplementation(async (name) => {
+        if (name === 'pnpm-workspace.yaml') return;
+        if (name === '.yarnrc.yml') return;
        if (Array.isArray(name) && name.includes('package.json'))
          return '/workspace/packages/app/package.json';
        return;
+        return;


This block starts a mockImplementation and then immediately starts another nested mockImplementation without closing the first one, which makes the test file syntactically invalid. Consolidate to a single findUp mock implementation (sync or async) and ensure braces/parentheses are correctly closed.

Suggested change

vi.mocked(findUp).mockImplementation((name) => {

if (name === 'pnpm-workspace.yaml') return;

if (name === '.yarnrc.yml') return;

vi.mocked(findUp).mockImplementation(async (name) => {

if (name === 'pnpm-workspace.yaml') return;

if (name === '.yarnrc.yml') return;

if (Array.isArray(name) && name.includes('package.json'))

return '/workspace/packages/app/package.json';

return;

return;

vi.mocked(findUp).mockImplementation(async (name) => {

if (name === 'pnpm-workspace.yaml') return;

if (name === '.yarnrc.yml') return;

if (Array.isArray(name) && name.includes('package.json'))

return '/workspace/packages/app/package.json';

return;

Copilot · 2026-02-10T20:34:18Z

packages/angular/README.md

-<h1 align="center">
-  Visit <a href="https://orval.dev" target="_blank">orval.dev</a> for docs, guides, API and beer!
-</h1>
+![orval - Restfull Client Generator](./logo/orval-logo-horizontal.svg?raw=true)


Typo in the image alt text: "Restfull" should be "Restful".

Suggested change

![orval - Restfull Client Generator](./logo/orval-logo-horizontal.svg?raw=true)

![orval - Restful Client Generator](./logo/orval-logo-horizontal.svg?raw=true)

Copilot · 2026-02-10T20:34:18Z

packages/orval/src/utils/package-json.test.ts

 import { isString as isRemedaString } from 'remeda';
+import { isString as isRemedaString } from 'remeda';


Duplicate import of isString as isRemedaString will cause a TypeScript compile error (duplicate identifier). Remove the extra import so it is declared only once.

Copilot · 2026-02-10T20:34:18Z

packages/orval/src/utils/package-json.test.ts

+import { dynamicImport, log } from '@orval/core';
 import { dynamicImport, log } from '@orval/core';
 import { findUp, findUpMultiple } from 'find-up';


Duplicate import of dynamicImport/log from @orval/core will cause a TypeScript compile error (duplicate identifier). Keep a single import statement.

Copilot · 2026-02-10T20:34:19Z

packages/orval/src/utils/package-json.test.ts

+        return;
      });



This mocked findUp implementation contains unreachable duplicated return; statements. Remove the extra return to avoid dead code and keep the mock implementation clear.

Suggested change

return;

});

});

Copilot · 2026-02-10T20:34:19Z

packages/orval/src/utils/package-json.test.ts

      const mockPkg = {
        devDependencies: {
-          jest: 'catalog:testing',
+          jest: 'catalog:ing',


jest is set to catalog:ing, but the test data expects a named catalog testing. As written, the resolver under test won't find a matching catalog and the assertion will fail; update the fixture to catalog:testing (or adjust the expected catalogs accordingly).

Suggested change

jest: 'catalog:ing',

jest: 'catalog:testing',

Copilot · 2026-02-10T20:34:19Z

packages/orval/src/utils/package-json.test.ts

      const mockPkg = {
        devDependencies: {
-          vitest: 'catalog:testing',
+          vitest: 'catalog:ing',


vitest is set to catalog:ing, but the test data expects a named catalog testing. This will prevent the resolver from finding the catalog entry and will fail the assertion; use catalog:testing (or update the expected catalogs).

Suggested change

vitest: 'catalog:ing',

vitest: 'catalog:testing',

Copilot · 2026-02-10T20:34:19Z

samples/angular-app/src/api/http-resource-zod/pets/pets.msw.ts

+      return new HttpResponse(
+        overrideResponse !== undefined
+          ? typeof overrideResponse === 'function'
+            ? await overrideResponse(info)
+            : overrideResponse
+          : getShowPetByIdResponseMock(),
+        { status: 200, headers: { 'Content-Type': 'text/plain' } },
+      );


getShowPetByIdMockHandler returns an object from getShowPetByIdResponseMock() but responds as text/plain without serialization. This is likely invalid for MSW HttpResponse; either return a string body for text/plain or serialize/use HttpResponse.json() with application/json.

Copilot · 2026-02-10T20:34:20Z

samples/angular-app/src/api/http-resource-zod/pets/pets.msw.ts

+      return new HttpResponse(
+        JSON.stringify(
+          overrideResponse !== undefined
+            ? typeof overrideResponse === 'function'
+              ? await overrideResponse(info)
+              : overrideResponse
+            : getDownloadFileResponseMock(),
+        ),
+        { status: 200, headers: { 'Content-Type': 'application/json' } },
+      );


getDownloadFileMockHandler JSON-stringifies a Blob and sets Content-Type: application/json, which won't mock a binary response correctly. Return the Blob directly and set a binary content type (or the actual file type).

the-ult · 2026-02-11T13:19:14Z

This PR is on hold until these PR's / issues are merged:

MSW mock generation: invalid faker ranges, Blob typing, and @type property sanitization #2934
Angular client output imports DeepNonNullable from @orval/core (breaks pnpm strict deps) #2930
Zod schema generation (split mode): multiple codegen bugs requiring post-processing workarounds #2933
Angular client codegen: missing type-only imports + incorrect HttpClient params typing #2931
fix(angular): angular-codegen typing issues for Zod imports, params handling, and response schemas #2938
Fix(core) linting #2937

the-ult · 2026-02-12T23:26:54Z

#2938 938 made a lot of changes and fixes to the angular generator.

In this pr we split it into http-client.ts and other files.

@copilot create a plan what would be the best way to merge these improvements into this PR

the-ult · 2026-02-19T14:34:26Z

Gonna be on holiday for a week. Gonna pick this up after :-)

The Ult added 6 commits February 8, 2026 01:42

feat(samples/angular): add httpResource demo

5a291a9

Split generated API outputs into http-client and http-resource targets\nwith updated MSW mocks and sample pages. Add routing and UI for the new httpResource screen plus the versioned\npath transformer used by both outputs.

chore(lint): expand lint tooling

0665317

Add lint:generated task wiring across root and tests, and update\nturbo pipeline + README guidance. Introduce ESLint configs for Angular/Next samples and refresh Angular\ncatalog + dependencies to include Angular ESLint support.

feat(angular): expand httpResource zod support

d60eccd

- add url-only httpResource generation and zod parse options - normalize angular runtimeValidation and update config/types/tests - document httpResource output and add zod sample pages/output

fix(mock): normalize MSW delay handling

ecf6a2a

- precompute delay expressions to handle function delays safely - expand MSW tests and update angular sample mocks - expose MSW_DELAY in turbo global env

fix(orval): clean schema dir with object paths

3682f86

- resolve schema path when schemas is an object - avoid cleaning the wrong directory during generation

Copilot AI review requested due to automatic review settings February 8, 2026 13:58

Copilot started reviewing on behalf of the-ult February 8, 2026 13:59 View session

the-ult mentioned this pull request Feb 8, 2026

Support Angular httpResource API #2316

Open

Copilot AI reviewed Feb 8, 2026

View reviewed changes

The Ult added 2 commits February 8, 2026 15:39

chore: reorganize yarn catalogs

0dc8fad

chore: update vscode markdown formatter

f7a34c9

melloware added the angular Related to Angular generation issues label Feb 8, 2026

The Ult added 8 commits February 8, 2026 09:51

feat(samples/angular): add httpResource demo

08d7aea

Split generated API outputs into http-client and http-resource targets\nwith updated MSW mocks and sample pages. Add routing and UI for the new httpResource screen plus the versioned\npath transformer used by both outputs.

chore(lint): expand lint tooling

e0dc4f4

Add lint:generated task wiring across root and tests, and update\nturbo pipeline + README guidance. Introduce ESLint configs for Angular/Next samples and refresh Angular\ncatalog + dependencies to include Angular ESLint support.

feat(angular): expand httpResource zod support

9ebdb94

- add url-only httpResource generation and zod parse options - normalize angular runtimeValidation and update config/types/tests - document httpResource output and add zod sample pages/output

fix(mock): normalize MSW delay handling

d8f7d45

- precompute delay expressions to handle function delays safely - expand MSW tests and update angular sample mocks - expose MSW_DELAY in turbo global env

fix(orval): clean schema dir with object paths

6425cb6

- resolve schema path when schemas is an object - avoid cleaning the wrong directory during generation

chore: reorganize yarn catalogs

4f34b33

chore: update vscode markdown formatter

ef1c58c

melloware force-pushed the feat/add-angular-http-resource branch from f7a34c9 to ef1c58c Compare February 8, 2026 14:51

The Ult added 3 commits February 8, 2026 17:06

Merge remote-tracking branch 'refs/remotes/origin/feat/add-angular-ht…

35b1bf9

…tp-resource' into feat/add-angular-http-resource

fix(query): align angular mutation callbacks

8e7fc3e

The Ult added 8 commits February 8, 2026 20:51

feat(samples/angular): add httpResource demo

15ec117

Split generated API outputs into http-client and http-resource targets\nwith updated MSW mocks and sample pages. Add routing and UI for the new httpResource screen plus the versioned\npath transformer used by both outputs.

feat(angular): expand httpResource zod support

b2c5910

- add url-only httpResource generation and zod parse options - normalize angular runtimeValidation and update config/types/tests - document httpResource output and add zod sample pages/output

chore: limit feature scope

e810b7d

chore: add angular-app lint config

9c5cac2

build(vscode): revert adding prettier for markdown

2ee7776

chore: revert out-of-scope changes

689630d

Merge branch 'pr-angular-httpresource'

e8745b8

melloware marked this pull request as draft February 9, 2026 12:50

build(deps): remove catalogs

b30c757

Revert back to not using yarn catalogs. But had to update some packages, due to yarn warnings.

the-ult commented Feb 9, 2026

View reviewed changes

packages/hono/package.json Show resolved Hide resolved

The Ult added 10 commits February 9, 2026 17:25

chore(samples): revert lint command

7dd1dd1

Use next lint instead of eslint

chore(deps): use typescript 5.9.3

48836b7

chore(deps): revert and fix dependencies

0bbe8b1

revert scope creep, as much as possible

chore(mock): revert msw fixes

ed64d7c

Will be done in separate PR

chore: revert out of scope package updates

f8e8f67

chore(deps): update catalog for angular

66f353e

chore(samples/angular-app): fix esling.config merge conflicts

35724d1

Merge remote-tracking branch 'origin/master' into feat/add-angular-ht…

cde5d29

…tp-resource

Merge remote-tracking branch 'origin/master' into feat/add-angular-ht…

7cf237c

…tp-resource

the-ult requested a review from Copilot February 10, 2026 20:28

Copilot started reviewing on behalf of the-ult February 10, 2026 20:28 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

the-ult mentioned this pull request Feb 10, 2026

MSW mock generation: invalid faker ranges, Blob typing, and @type property sanitization #2934

Closed

The Ult added 2 commits February 10, 2026 22:25

docs(angular): correct spelling of "Restfull" to "Restful" in README.md

3abf026

fix(test): repair package-json catalog mocks

046eebe

		@@ -57,10 +65,6 @@ const getGeneratorClient = (
		? outputClient(GENERATOR_CLIENT)
		: GENERATOR_CLIENT[outputClient];

+  if (!generator) {
+    throw new Error(
+      `Unknown output client provided to getGeneratorClient: ${String(outputClient)}`,
+    );
+  }

		if (isResponseArrayBuffer(contentType)) return 'httpResource.arrayBuffer';
		if (isResponseBlob(contentType, response.isBlob)) return 'httpResource.blob';

	![orval - Restfull Client Generator](./logo/orval-logo-horizontal.svg?raw=true)
	![orval - Restful Client Generator](./logo/orval-logo-horizontal.svg?raw=true)

		import { isString as isRemedaString } from 'remeda';
		import { isString as isRemedaString } from 'remeda';

Uh oh!

Comments

Conversation

the-ult commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related issue

Primary focus — httpResource generation (packages/angular + core)

Expanded Angular sample app (samples/angular-app)

Docs & guidance

Other improvements / related fixes

Angular Query compatibility fix

Other unrelated changes

Tests

Uh oh!

the-ult commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

ScriptType commented Feb 8, 2026

Uh oh!

the-ult commented Feb 8, 2026

Uh oh!

melloware commented Feb 8, 2026

Uh oh!

ScriptType commented Feb 8, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

the-ult commented Feb 8, 2026 •

edited

Loading

the-ult commented Feb 8, 2026 •

edited

Loading