Skip to content

feat: add ui helper for div#416

Merged
aeneasr merged 1 commit intomasterfrom
add-missing-div-ui-helper
Apr 29, 2025
Merged

feat: add ui helper for div#416
aeneasr merged 1 commit intomasterfrom
add-missing-div-ui-helper

Conversation

@aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 29, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

@aeneasr aeneasr requested a review from jonas-jonas April 29, 2025 13:40
@aeneasr aeneasr self-assigned this Apr 29, 2025
@aeneasr aeneasr requested a review from Copilot April 29, 2025 13:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new UI helper that provides a TypeScript type guard for <div> nodes.

  • Added import for UiNodeDivisionAttributes.
  • Introduced isUiNodeDivAttributes to check for node_type "div".
Comments suppressed due to low confidence (1)

contrib/fetch/src/ui.ts:82

  • The function name 'isUiNodeDivAttributes' is inconsistent with the full type name 'UiNodeDivisionAttributes'. Consider renaming it to 'isUiNodeDivisionAttributes' for consistency.
export function isUiNodeDivAttributes(

@aeneasr aeneasr merged commit fb952c0 into master Apr 29, 2025
2 checks passed
@aeneasr aeneasr deleted the add-missing-div-ui-helper branch April 29, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants