Skip to content

Fix #424#426

Merged
aeneasr merged 1 commit intoory:masterfrom
lol768:fix/424
May 16, 2025
Merged

Fix #424#426
aeneasr merged 1 commit intoory:masterfrom
lol768:fix/424

Conversation

@lol768
Copy link
Contributor

@lol768 lol768 commented May 16, 2025

v7.12.0 changed the default csharp library to generichost, so updating the generator is all that is required.

See https://github.com/OpenAPITools/openapi-generator/releases/tag/v7.12.0

This PR fixes #424

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature. Not applicable, not a new feature
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works. Not applicable, would expect unit tests within upstream openapi-generator codebase
  • I have added the necessary documentation within the code base (if
    appropriate).
    • Happy to be guided by maintainers' views here.

Further comments

I am hopeful that the decision from upstream (openapi-generator) to change the default here will add some weight to the reasoning I provided in #424

v7.12.0 changed the default csharp library to generichost

So updating the generator is all that is required.

See https://github.com/OpenAPITools/openapi-generator/releases/tag/v7.12.0
@aeneasr aeneasr merged commit 466873d into ory:master May 16, 2025
2 of 3 checks passed
@aeneasr
Copy link
Member

aeneasr commented May 16, 2025

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please use "generichost" library option for csharp generator

2 participants