Prepare proper software release of Software Remesher#1
Open
dmikushin wants to merge 22 commits intoorzzzjq:masterfrom
Open
Prepare proper software release of Software Remesher#1dmikushin wants to merge 22 commits intoorzzzjq:masterfrom
dmikushin wants to merge 22 commits intoorzzzjq:masterfrom
Conversation
…container for building
…CUDA compiler and resolve the following link error:
/usr/bin/ld: CMakeFiles/surfremesh.dir/src/gDel2D/gDel2D/GPU/GpuDelaunay.cu.o: in function `GpuDel::doInsertConstraints()':
tmpxft_000003c2_00000000-6_GpuDelaunay.cudafe1.cpp:(.text+0x34dc): undefined reference to `Visualizer::addFrame(DevVector<Point2> const&, DevVector<Segment> const&, DevVector<Tri> const&, thrust::THRUST_200500_800_NS::host_vector<int, std::allocator<int> > const&, int)'
/usr/bin/ld: tmpxft_000003c2_00000000-6_GpuDelaunay.cudafe1.cpp:(.text+0x363c): undefined reference to `Visualizer::addFrame(DevVector<Point2> const&, DevVector<Segment> const&, DevVector<Tri> const&, thrust::THRUST_200500_800_NS::host_vector<int, std::allocator<int> > const&, int)'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/surfremesh.dir/build.make:334: surfremesh] Error 1
This symbol is requested:
$ nm -C CMakeFiles/surfremesh.dir/src/gDel2D/gDel2D/GPU/GpuDelaunay.cu.o | grep addFrame
U Visualizer::addFrame(DevVector<Point2> const&, DevVector<Segment> const&, DevVector<Tri> const&, thrust::THRUST_200500_800_NS::host_vector<int, std::allocator<int> > const&, int)
However, only this symbol is present:
$ nm -C CMakeFiles/surfremesh.dir/src/gDel2D/Visualizer.cpp.o | grep addFrame
0000000000003724 T Visualizer::addFrame(DevVector<Point2> const&, DevVector<Tri> const&, int)
0000000000003a06 T Visualizer::addFrame(DevVector<Point2> const&, DevVector<Segment> const&, DevVector<Tri> const&, thrust::THRUST_200500___CUDA_ARCH_LIST___NS::host_vector<int, std::allocator<int> > const&, int)
Note there is "__CUDA_ARCH_LIST__" instead of "800" in the name, because "__CUDA_ARCH_LIST__" in CMake this macro is only substituted by the CUDA compiler. Therefore, the easiest fix is to use CUDA compiler for Visualizer.cpp
… main.cpp: If the CGAL includes order is different sometimes GCC and Clang both fail with weird template substitution errors. This is probably a defect in CGAL. The issue was tracked down by comparing the main.cpp to a similar seam_Polyhedron_3.cpp CGAL example.
…st to namespace-based targets
…es using pymeshlab and polyscope. Save the camera view, so that all subsequent screenshots use the same camera view
…ze these days; removing allows to drop many OpenGL-related dependencies
… parameters available as the function arguments
…sion is .json, load surfmesh arguments from .json; if .json also provides values for any optional arguments, use them instead of the defaults as well
* Adding command line description * Adding --choose-scene command line option, which will enforce choosing the scene and overwrite existing JSON with cached scene
Owner
|
Hi @dmikushin, Thank you so much for your contribution and suggestions to the project. I was traveling in the past few days therefore didn't reply at once. Your suggestion of using Docker is great. However, personally I am not quite familiar with Docker. I will check it recently and considering merging your commits into the repo once I figure out how it works. |
Author
|
Hi @orzzzjq , thank you for the reply, and do not hesitate to ask me about anything. Have a good travel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @orzzzjq ,
Thank you for publishing the source code of Surface Remesher.
I understand that Surface Remesher is the academic work, so its source code is not production-ready, and polishing the source code is not an academic goal.
This PR makes Surface Remesher code ready for deployment in the following ways:
I wish to extend this work with Python API and Blender plugin, but currently don't have time. I hope you'll like this PR as it is.