Validate conf files in the worker container#247
Validate conf files in the worker container#247d3flex wants to merge 1 commit intoos-autoinst:masterfrom
Conversation
Just a small improvement in order to validate what is mount in the container as the `wait_for_container_log` confirms that it cannot find any keys but we do not know whether the configs which reads are as expected. related poo: https://progress.opensuse.org/issues/186651 Signed-off-by: Ioannis Bonatakis <ybonatakis@suse.com>
|
perlpunk
left a comment
perlpunk
left a comment
There was a problem hiding this comment.
so you're basically just checking whether the volume option in docker works correctly?
| $confs{worker_ini}{output} = script_output("cat $data_container_path$confs{worker_ini}{path}"); | ||
|
|
||
| assert_script_run("docker run -d --network testing $volumes --name openqa_worker openqa_worker"); | ||
| wait_for_container_log('openqa_worker', 'API key and secret are needed', 'docker'); |
There was a problem hiding this comment.
Why aren't you addressing this error message? If that's gone we would know config was ready and the connection works, no?
There was a problem hiding this comment.
Addressing means? If you mean get a registred worker, that it would imply more changes, as it needs to be clear (at least to me) what is the intention. As I mentioned, I think the message (API key and secret are needed) here is the expected one.
There was a problem hiding this comment.
Right now the worker test prepares a container and validates that it is not able to connect to a web UI.
If you're saying we should test both this, and the case of a successful connection I would say, yes, that makes sense.
There was a problem hiding this comment.
So we want to redesign the modules?
Does it mean that it will be better a multimachine test?
in any case this PR is just an additional check. it wasnt intented to change how things are now.
Ensure that the |
3 participants
Just a small improvement in order to validate what is mount in the container as the
wait_for_container_logconfirms that it cannot find any keys but we do not know whether the configs which reads are as expected.related poo: https://progress.opensuse.org/issues/186651