Prevent cloning useless assets to fix stability and optimize#266
Draft
okurz wants to merge 2 commits intoos-autoinst:masterfrom
Draft
Prevent cloning useless assets to fix stability and optimize#266okurz wants to merge 2 commits intoos-autoinst:masterfrom
okurz wants to merge 2 commits intoos-autoinst:masterfrom
Conversation
Member
Author
|
The line |
The current values for UEFI_PFLASH_CODE and UEFI_PFLASH_VARS have been selected not too long ago in 7531e39 even though the variables have been originally introduced in 216974e. In both commits as well as the related pull request and even linked tickets no good explanation was stated why such settings would be necessary. https://progress.opensuse.org/issues/193258 has shown that those settings are actually harmful as adding a virtio-keyboard which allows to fix VNC typing issues broke test execution. Removing those variables is preferred as they are not needed and have no justification and allows us to fix VNC typing issues. Verification test: https://openqa.opensuse.org/tests/5512174 Related progress issue: https://progress.opensuse.org/issues/113441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant progress issue: https://progress.opensuse.org/issues/193345
openqa-Tumbleweed-dev-x86_64-Build:TW.40550-openqa_install_multimachine@uefi-4G -> https://openqa.opensuse.org/tests/5495731