Avoid set proxy SCC for registration on Full medium#25003
Open
lemon-suse wants to merge 1 commit intoos-autoinst:masterfrom
Open
Avoid set proxy SCC for registration on Full medium#25003lemon-suse wants to merge 1 commit intoos-autoinst:masterfrom
lemon-suse wants to merge 1 commit intoos-autoinst:masterfrom
Conversation
jknphy
reviewed
Mar 18, 2026
lemon-suse
force-pushed
the
avoid-set-proxy-for-full-medium
branch
from
82d46c1 to
4cda6d5
Compare
lemon-suse
force-pushed
the
avoid-set-proxy-for-full-medium
branch
2 times, most recently
from
c835c56 to
6bb737e
Compare
jknphy
reviewed
Mar 19, 2026
tests/boot/boot_from_pxe.pm
Outdated
| } | ||
|
|
||
| if (check_var('SCC_REGISTER', 'installation') && !(check_var('VIRT_AUTOTEST', 1) && check_var('INSTALL_TO_OTHERS', 1))) { | ||
| if (check_var('SCC_REGISTER', 'installation') && !(check_var('VIRT_AUTOTEST', 1) && check_var('INSTALL_TO_OTHERS', 1)) && (!(is_agama && check_var('FLAVOR', 'Full')))) { |
Contributor
There was a problem hiding this comment.
I think we are the only ones testing Full medium, you can skip this change.
jknphy
reviewed
Mar 19, 2026
| $cmdline .= get_var('EXTRABOOTPARAMS') . ' ' if get_var('EXTRABOOTPARAMS'); | ||
| $cmdline .= ' ' . join(' ', autoyast_boot_params) if (get_var('AUTOYAST')); | ||
| $cmdline .= registration_bootloader_cmdline . ' ' if check_var('SCC_REGISTER', 'installation'); | ||
| if (!(is_agama && check_var('FLAVOR', 'Full'))) { |
Contributor
There was a problem hiding this comment.
I think we are the only ones testing Full medium, you can skip this change too.
lemon-suse
force-pushed
the
avoid-set-proxy-for-full-medium
branch
from
6bb737e to
aec44ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.