Open
Conversation
added 6 commits
March 18, 2026 13:24
We had many lines that were almost exactly the same and were copied over and only slightly changed. This should be done in a seperate function.
We are re-using the same code again and again - so better move this into it's own function.
We can refactor the kernel config checking into a seperate funtion. However, the old code was flawed: if a config option was missing, we would just have skipped the tests and produce a green bubble. Now we will fail, with the ability to softfail with a variable if, for example, we want to ignore missing config optins in kernel config Also, we can remove a unneeded barrier so we can have even cleaner code in nfs-client.pm
Move the function verify_nfs_support to the newly created library and fix it. Make both client and server code use this functiont.
Also include some minor fixes/changes to the function
We can verify the files created by the client in a much less repetetive way. Also this can go to the library code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[type description here, PLEASE, REMOVE THIS LINE, PLACEHOLDER, BEFORE SUBMITTING THIS PULL REQUEST]