Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Oct 10, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

  1. Modified the workflow to use a Python virtual environment when installing Python packages, instead of attempting system-wide installations, which avoids triggering the externally-managed-environment error.
  2. Added steps to set up a virtual environment for Python and install dependencies within it for systems where the environment is managed (e.g., Ubuntu 22.04).

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts rpe_test.yml

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.95%. Comparing base (94f5660) to head (7e9e2a7).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (94f5660) and HEAD (7e9e2a7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (94f5660) HEAD (7e9e2a7)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #227       +/-   ##
===========================================
- Coverage   68.06%   51.95%   -16.11%     
===========================================
  Files         109       55       -54     
  Lines        8527     1634     -6893     
===========================================
- Hits         5804      849     -4955     
+ Misses       2723      785     -1938     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158 shivaahir158 changed the title python dependency fix Fix for externally-managed-environment Error for setting up Python virtual environment Oct 10, 2024
@shivaahir158 shivaahir158 marked this pull request as ready for review October 10, 2024 18:19
@shivaahir158 shivaahir158 merged commit b0c77b5 into main Oct 10, 2024
10 of 11 checks passed
@shivaahir158 shivaahir158 deleted the task/Python-depencencies-fix-in-rpe branch October 10, 2024 18:24
@ravikiranchollangi
Copy link
Contributor

@shivaahir158 @NadeemYaseen before approval and merge, please keep an eye on the coverage, it has gone down significantly.
image

@shivaahir158
Copy link
Collaborator Author

Hi @ravikiranchollangi , I checked and codecov is only capturing 'src' folder, it is not capturing 'backend' and 'tests' (backend tests) folder, let me look into this and discuss this with @NadeemYaseen .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants