-
Notifications
You must be signed in to change notification settings - Fork 4
Simple logger for backend log messages #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple logger for backend log messages #230
Conversation
chernyee
commented
Oct 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 68.24% 68.35% +0.11%
==========================================
Files 109 110 +1
Lines 8527 8574 +47
==========================================
+ Hits 5819 5861 +42
- Misses 2708 2713 +5 ☔ View full report in Codecov by Sentry. |
shivaahir158
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me after discussing the ticket.
|
I need to review this one, will merge after. |
| if not logger.handlers: | ||
| logger.addHandler(get_file_handler(filename, max_bytes, backup_count)) | ||
| logger.addHandler(get_console_handler()) | ||
| logger.setLevel(logging.DEBUG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default log level as debug is ok for now, we should revisit this when we go to production. Also, it must be read from raptor-dev.json if we need to change the level.
These are near future enhancements.