Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

  1. Verifies that the modal title is displayed correctly.
  2. Makes sure the closeModal function is called when the cancel button is clicked.
  3. Tests that the onSubmit function is called with the correct data when the form is submitted.
  4. Checks that form fields (e.g., RTL Port Name, bus width, clock selection) are updated when the user changes their values.

Which part of the code base require a change

  • Frontend: IOModal.test.js
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@shivaahir158 shivaahir158 self-assigned this Oct 11, 2024
@shivaahir158 shivaahir158 marked this pull request as ready for review October 11, 2024 17:35
@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.19%. Comparing base (086fe62) to head (34490ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   68.06%   68.19%   +0.12%     
==========================================
  Files         109      109              
  Lines        8527     8527              
==========================================
+ Hits         5804     5815      +11     
+ Misses       2723     2712      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravikiranchollangi ravikiranchollangi merged commit 1cd7795 into main Oct 11, 2024
11 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/RPE-131/FE-React-Jest-Test-for-IOModal.js branch October 11, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants