Skip to content

Conversation

@chernyee
Copy link
Collaborator

@chernyee chernyee commented Oct 14, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Changes:

  1. Allow devices without power_data config in device.xml to be loaded in RPE
  2. Do not raise exception if a device has not power_data config.
  3. Do not exit backend process when a device has not power_data config
  4. Allow RPE to run even there are devices without power_data config.

Which part of the code base require a change

  • Frontend:
  • Backend: DeviceManager, PowerCfg modules
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.36%. Comparing base (b60093c) to head (ce2fc9a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/submodule/rs_device_resources.py 58.33% 5 Missing ⚠️
backend/submodule/rs_power_config.py 81.25% 3 Missing ⚠️
backend/submodule/rs_device.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   68.35%   68.36%           
=======================================
  Files         110      110           
  Lines        8574     8602   +28     
=======================================
+ Hits         5861     5881   +20     
- Misses       2713     2721    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chernyee chernyee merged commit f137fd7 into main Oct 14, 2024
11 checks passed
@chernyee chernyee deleted the task/RPE-134/skip-device-without-power-data branch October 14, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants