Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Oct 24, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

  1. Playwright Setup:
    Added playwright.config.js for Playwright testing setup. Created a new folder playwright_e2e/ with test files for ACPU, BCPU, DSP, FLE, and clocking
  2. Updated jest.config.js to exclude some folders and improve test coverage.
  3. Adjusted the setup for better Playwright integration.
  4. Updated .gitignore to ignore Playwright test results, reports, and cache files.

Which part of the code base require a change

  • Frontend: playwright tests
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (2ce7972) to head (f50df71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   69.20%   68.67%   -0.53%     
==========================================
  Files         110      110              
  Lines        8674     9045     +371     
  Branches        0      402     +402     
==========================================
+ Hits         6003     6212     +209     
- Misses       2671     2833     +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158
Copy link
Collaborator Author

@NadeemYaseen, this is as we discussed. Please connect with me once you are in your working hours.

@shivaahir158 shivaahir158 changed the title setting up playwright testing env and config.js Setting up Playwright testing env and config.js Oct 24, 2024
@shivaahir158 shivaahir158 marked this pull request as ready for review October 24, 2024 20:36
Copy link
Contributor

@ravikiranchollangi ravikiranchollangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these tests to the following folder.
https://github.com/os-fpga/rapid_power_estimator/tree/main/tests/e2e

@shivaahir158
Copy link
Collaborator Author

shivaahir158 commented Oct 24, 2024

@ravikiranchollangi , this 'test' folder is for the backend tests, frontend tests are 'test' folder under 'src'.

Do you still want me to move the tests under the 'playwright_e2e' to the test folder where backend tests are located? Let me know so I shall do the needful.

@shivaahir158 shivaahir158 deleted the task/153/setting-up-playwright branch October 24, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants