Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Oct 24, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

  1. Playwright Setup:
    Added playwright.config.js for Playwright testing setup. Created a new folder playwright_e2e/ with test files for ACPU, BCPU, DSP, FLE, and clocking
  2. Updated jest.config.js to exclude some folders and improve test coverage.
  3. Adjusted the setup for better Playwright integration.
  4. Updated .gitignore to ignore Playwright test results, reports, and cache files.
  5. As discussed, creating a test folder named 'e2e' under 'tests' folder as our desired location for Playwright test suites.

Which part of the code base require a change

  • Frontend: playwright tests
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@shivaahir158 shivaahir158 changed the title adding e2e folder under tests Setting up Playwright testing env and config.js, adding e2e folder under tests Oct 24, 2024
@shivaahir158 shivaahir158 marked this pull request as ready for review October 24, 2024 23:35
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a06c9c9). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage        ?   68.67%           
=======================================
  Files           ?      110           
  Lines           ?     9045           
  Branches        ?      402           
=======================================
  Hits            ?     6212           
  Misses          ?     2833           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158 shivaahir158 self-assigned this Oct 24, 2024
@NadeemYaseen NadeemYaseen force-pushed the task/153/setting-up-e2e-under-test branch from adce86e to 8dcab9d Compare October 25, 2024 10:36
@ravikiranchollangi
Copy link
Contributor

@NadeemYaseen these looks to be outdated, please remove if you can.
image

@ravikiranchollangi ravikiranchollangi merged commit 28de7a5 into main Oct 30, 2024
19 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/153/setting-up-e2e-under-test branch October 30, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants