-
Notifications
You must be signed in to change notification settings - Fork 4
Setting up e2e under test GitHub ci setup #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up e2e under test GitHub ci setup #253
Conversation
…ng-up-e2e-under-test_githubCISetup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## task/153/setting-up-e2e-under-test #253 +/- ##
======================================================================
- Coverage 70.26% 68.67% -1.59%
======================================================================
Files 55 110 +55
Lines 7035 9045 +2010
Branches 0 402 +402
======================================================================
+ Hits 4943 6212 +1269
- Misses 2092 2833 +741 ☔ View full report in Codecov by Sentry. |
|
@shivaahir158 The CI was passed on Friday, see here but now it is failing with the error below like this |
|
@NadeemYaseen check now |
|
@shivaahir158 Please approve and squash merge. |
Thanks @shivaahir158, could you please explain the fix to selectors ? Why we didn't catch it in previous commits or locally ? |
1 similar comment
Thanks @shivaahir158, could you please explain the fix to selectors ? Why we didn't catch it in previous commits or locally ? |
@ravikiranchollangi , I have fixed the selector for clicking on 'ok' button after giving inputs to clocking, it was not clicking on it, but I fixed the selector for it, and the jobs are ok. The selector for the OK button in the test was updated because the class name changed in the UI from niikz0 to apm68, causing the test to fail. |
7664d65
into
task/153/setting-up-e2e-under-test
…der tests (#250) * adding e2e folder under tests * adding condition for e2e tests in jest.config.js * Setting up e2e under test GitHub ci setup (#253) --------- Co-authored-by: Ravikiran Chollangi <[email protected]> Co-authored-by: Nadeem Yaseen <[email protected]>
Setting up E2E test in GH CI.