Skip to content

Conversation

@NadeemYaseen
Copy link
Contributor

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • [ x] Breaking new feature. If so, please describe details in the description part.

Setting up E2E test in GH CI.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • [x ] Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (d6924ad) to head (3d85f03).
Report is 1 commits behind head on task/153/setting-up-e2e-under-test.

Additional details and impacted files
@@                          Coverage Diff                           @@
##           task/153/setting-up-e2e-under-test     #253      +/-   ##
======================================================================
- Coverage                               70.26%   68.67%   -1.59%     
======================================================================
  Files                                      55      110      +55     
  Lines                                    7035     9045    +2010     
  Branches                                    0      402     +402     
======================================================================
+ Hits                                     4943     6212    +1269     
- Misses                                   2092     2833     +741     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NadeemYaseen
Copy link
Contributor Author

@shivaahir158 The CI was passed on Friday, see here but now it is failing with the error below like this
Can you look into this by cloning my branch and running a test locally to confirm this is purely a CI error?
By the way, 2 tests are passing in CI.

@shivaahir158
Copy link
Collaborator

@NadeemYaseen check now

@NadeemYaseen
Copy link
Contributor Author

@shivaahir158 Please approve and squash merge.

@ravikiranchollangi
Copy link
Contributor

@NadeemYaseen check now

Thanks @shivaahir158, could you please explain the fix to selectors ? Why we didn't catch it in previous commits or locally ?

1 similar comment
@ravikiranchollangi
Copy link
Contributor

@NadeemYaseen check now

Thanks @shivaahir158, could you please explain the fix to selectors ? Why we didn't catch it in previous commits or locally ?

@shivaahir158
Copy link
Collaborator

@NadeemYaseen check now

Thanks @shivaahir158, could you please explain the fix to selectors ? Why we didn't catch it in previous commits or locally ?

@ravikiranchollangi , I have fixed the selector for clicking on 'ok' button after giving inputs to clocking, it was not clicking on it, but I fixed the selector for it, and the jobs are ok. The selector for the OK button in the test was updated because the class name changed in the UI from niikz0 to apm68, causing the test to fail.

@ravikiranchollangi ravikiranchollangi merged commit 7664d65 into task/153/setting-up-e2e-under-test Oct 29, 2024
18 of 19 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/153/setting-up-e2e-under-test_githubCISetup branch October 29, 2024 18:30
ravikiranchollangi added a commit that referenced this pull request Oct 30, 2024
…der tests (#250)

* adding e2e folder under tests

* adding condition for e2e tests in jest.config.js

* Setting up e2e under test GitHub ci setup (#253)

---------

Co-authored-by: Ravikiran Chollangi <[email protected]>
Co-authored-by: Nadeem Yaseen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants