Skip to content

Conversation

@chernyee
Copy link
Collaborator

@chernyee chernyee commented Oct 30, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Changes:

  • Improve Device Power Config to handle optional resources
  • Delete the 'etc' folder which contains the device power config files
  • Remove hardcoded resources used for development purpose

Which part of the code base require a change

  • Frontend:
  • Backend: PowerCfg Module
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 25.24272% with 77 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (efcd133) to head (7d553c7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/submodule/io.py 14.70% 29 Missing ⚠️
backend/submodule/bram.py 22.22% 21 Missing ⚠️
backend/submodule/dsp.py 23.07% 20 Missing ⚠️
backend/submodule/peripherals.py 0.00% 3 Missing ⚠️
backend/submodule/rs_device_resources.py 57.14% 3 Missing ⚠️
backend/submodule/rs_device.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   68.67%   68.83%   +0.15%     
==========================================
  Files         110      110              
  Lines        9045     9022      -23     
  Branches      402      402              
==========================================
- Hits         6212     6210       -2     
+ Misses       2833     2812      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravikiranchollangi ravikiranchollangi merged commit 03e2e77 into main Oct 30, 2024
18 of 19 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/RPE-102/delete_etc_n_pwr_cfg_code_enhance branch October 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants