Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Oct 30, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

Commenting Playwright tests for now.
The selectors that we have captured are dynamic and brittle and are changing over time.
Need to find a pathway to add stable selectors.

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend: tests/e2e
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts: run_test.yml

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (28de7a5) to head (b242b14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   68.67%   68.67%           
=======================================
  Files         110      110           
  Lines        9045     9045           
  Branches      402      402           
=======================================
  Hits         6212     6212           
  Misses       2833     2833           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158 shivaahir158 changed the title commenting playwright tests for now Commenting playwright tests for now Oct 30, 2024
@shivaahir158 shivaahir158 marked this pull request as ready for review October 30, 2024 14:45
@shivaahir158 shivaahir158 merged commit efcd133 into main Oct 30, 2024
19 checks passed
@shivaahir158 shivaahir158 deleted the commenting-playwright-tests branch October 30, 2024 14:59
@shivaahir158 shivaahir158 self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants