Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Nov 6, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

Testing Playwright tests.

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests: tests/e2e/
  • Continuous Integration (CI) scripts: rpe_test.yml

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@shivaahir158 shivaahir158 self-assigned this Nov 6, 2024
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (e89099e) to head (06b39d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         110      110           
  Lines        9022     9022           
  Branches      402      402           
=======================================
  Hits         6210     6210           
  Misses       2812     2812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158
Copy link
Collaborator Author

Hi @NadeemYaseen I verified that the Playwright tests run successfully on my local machine. For the rpe_test.yml file, we should set it up so that the app launches with npm start, then closes, and relaunches before the tests execute, I believe the tests would run successfully then.

@shivaahir158 shivaahir158 marked this pull request as ready for review November 8, 2024 16:29
Copy link
Contributor

@ravikiranchollangi ravikiranchollangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a standard way to describe the testcases within the testfile.

Copy link
Contributor

@ravikiranchollangi ravikiranchollangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging these for CI changes mostly as we still have some work to do in test files (follow up PRs).

@ravikiranchollangi ravikiranchollangi merged commit a75e247 into main Nov 8, 2024
19 checks passed
@ravikiranchollangi ravikiranchollangi deleted the playwright-tests branch November 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants