Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

  1. Adding signal handlers for shutting down the process to the backend (restapi_server.py).
  2. Added restart.test.js e2e test.

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend:
  • Backend: restapi_server.py
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests: e2e/restart.test.js
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (f7aa4b6) to head (90688b6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/restapi_server.py 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   68.83%   68.78%   -0.05%     
==========================================
  Files         110      110              
  Lines        9022     9035      +13     
  Branches      402      402              
==========================================
+ Hits         6210     6215       +5     
- Misses       2812     2820       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shivaahir158 shivaahir158 marked this pull request as ready for review November 18, 2024 20:15
@shivaahir158 shivaahir158 changed the title Added Signal Handlers to the backend and adding restart.test.js Added Signal Handlers to the backend for shutting down the process and adding restart.test.js Nov 18, 2024
@shivaahir158
Copy link
Collaborator Author

@NadeemYaseen , please check the changes pushed we discussed for restart.test.js.

@NadeemYaseen
Copy link
Contributor

@NadeemYaseen , please check the changes pushed we discussed for restart.test.js.

The current test works locally on Linux. The use of kill command ensure that we are killing the backend process.

@ravikiranchollangi ravikiranchollangi merged commit 95c5fe1 into main Nov 20, 2024
9 of 11 checks passed
@ravikiranchollangi ravikiranchollangi deleted the shutdown-windows branch November 20, 2024 17:04
@shivaahir158 shivaahir158 self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants