Skip to content

Conversation

@NadeemYaseen
Copy link
Contributor

Motivate of the pull request

  • [x ] To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Webpack is optimising the Typescript in production mode due to this the frontend cannot fetch data from backend. So for now disabled the webpack production mode and package the assets in development mode.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • [ x] Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (fb4d21f) to head (925663d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   68.78%   68.78%           
=======================================
  Files         110      110           
  Lines        9035     9035           
  Branches      402      402           
=======================================
  Hits         6215     6215           
  Misses       2820     2820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158
Copy link
Collaborator

not sure why CI does not accept playwright tests every time, when it runs fine on local env, @NadeemYaseen lets take a call on these tests once you are back online.

@shivaahir158 shivaahir158 merged commit 0c0cab8 into main Nov 26, 2024
11 checks passed
@shivaahir158 shivaahir158 deleted the fix_packaging_in_linux branch November 26, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants